From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32195: 26.1; [PATCH] Support indirect buffers in `diff-buffer-with-file' Date: Fri, 27 Jul 2018 10:04:40 +0300 Message-ID: <83y3dxrwfr.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532674991 15395 195.159.176.226 (27 Jul 2018 07:03:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 27 Jul 2018 07:03:11 +0000 (UTC) Cc: 32195@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 27 09:03:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiwmH-0003pU-73 for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 09:03:05 +0200 Original-Received: from localhost ([::1]:39443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiwoM-0005US-1I for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Jul 2018 03:05:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiwoB-0005N3-0j for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 03:05:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiwoA-0004HC-9f for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 03:05:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fiwoA-0004Gp-6H for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 03:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fiwo9-0000bO-RM for bug-gnu-emacs@gnu.org; Fri, 27 Jul 2018 03:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jul 2018 07:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32195-submit@debbugs.gnu.org id=B32195.15326750952299 (code B ref 32195); Fri, 27 Jul 2018 07:05:01 +0000 Original-Received: (at 32195) by debbugs.gnu.org; 27 Jul 2018 07:04:55 +0000 Original-Received: from localhost ([127.0.0.1]:59480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiwo3-0000b0-8W for submit@debbugs.gnu.org; Fri, 27 Jul 2018 03:04:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fiwo1-0000ao-Qx for 32195@debbugs.gnu.org; Fri, 27 Jul 2018 03:04:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fiwnr-00042V-Mr for 32195@debbugs.gnu.org; Fri, 27 Jul 2018 03:04:48 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fiwnr-00042R-J8; Fri, 27 Jul 2018 03:04:43 -0400 Original-Received: from [176.228.60.248] (port=2797 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fiwnp-0008Fv-FM; Fri, 27 Jul 2018 03:04:42 -0400 In-reply-to: (message from Phil Sainty on Wed, 18 Jul 2018 19:50:26 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148994 Archived-At: > From: Phil Sainty > Date: Wed, 18 Jul 2018 19:50:26 +1200 > > In an indirect buffer `buffer-file-name' is nil, and consequently M-x > diff-buffer-with-file fails with "diff-no-select: Wrong type argument: > stringp, nil" > > I think it would be sensible to use the base buffer's file name in this > situation. > > Patch attached. Looks reasonable. Can you push (to the master branch), or do you need someone to do that for you? If the latter, please provide a commit log message. Thanks.