all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: 32195@debbugs.gnu.org
Subject: bug#32195: 26.1; [PATCH] Support indirect buffers in `diff-buffer-with-file'
Date: Fri, 27 Jul 2018 10:04:40 +0300	[thread overview]
Message-ID: <83y3dxrwfr.fsf@gnu.org> (raw)
In-Reply-To: <e31de6d4-d942-c8ff-8b47-a0cd6270b72e@orcon.net.nz> (message from Phil Sainty on Wed, 18 Jul 2018 19:50:26 +1200)

> From: Phil Sainty <psainty@orcon.net.nz>
> Date: Wed, 18 Jul 2018 19:50:26 +1200
> 
> In an indirect buffer `buffer-file-name' is nil, and consequently M-x
> diff-buffer-with-file fails with "diff-no-select: Wrong type argument:
> stringp, nil"
> 
> I think it would be sensible to use the base buffer's file name in this
> situation.
> 
> Patch attached.

Looks reasonable.  Can you push (to the master branch), or do you need
someone to do that for you?  If the latter, please provide a commit
log message.

Thanks.





  reply	other threads:[~2018-07-27  7:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18  7:50 bug#32195: 26.1; [PATCH] Support indirect buffers in `diff-buffer-with-file' Phil Sainty
2018-07-27  7:04 ` Eli Zaretskii [this message]
2018-07-28 12:38   ` Phil Sainty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y3dxrwfr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=32195@debbugs.gnu.org \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.