From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34179: 27.0.50; message hangs when buffer with process visible Date: Fri, 25 Jan 2019 12:15:14 +0200 Message-ID: <83y37959hp.fsf@gnu.org> References: <87fttj4dgj.fsf@web.de> <83ef938hik.fsf@gnu.org> <874l9yp50z.fsf@web.de> <87y37anpoj.fsf@web.de> <83pnsm6rxs.fsf@gnu.org> <878szanlua.fsf@web.de> <8736pinlk4.fsf@web.de> <87womum615.fsf@web.de> <87r2d2m5jf.fsf@web.de> <5C49E24F.7080800@gmx.at> <87d0olncf4.fsf@web.de> <877eetnba1.fsf@web.de> <83ef917tf7.fsf@gnu.org> <83bm457s49.fsf@gnu.org> <5C4ADA96.4010400@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111329"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael_heerdegen@web.de, 34179@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 25 11:50:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmz3t-000SrR-Nd for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jan 2019 11:50:13 +0100 Original-Received: from localhost ([127.0.0.1]:41877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmz3s-0008JA-JR for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Jan 2019 05:50:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmyWq-0006nw-UM for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 05:16:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmyWo-0007Yh-CK for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 05:16:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45282) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmyWo-0007YX-3i for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 05:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gmyWn-0001K2-Sh for bug-gnu-emacs@gnu.org; Fri, 25 Jan 2019 05:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Jan 2019 10:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34179 X-GNU-PR-Package: emacs Original-Received: via spool by 34179-submit@debbugs.gnu.org id=B34179.15484113415051 (code B ref 34179); Fri, 25 Jan 2019 10:16:01 +0000 Original-Received: (at 34179) by debbugs.gnu.org; 25 Jan 2019 10:15:41 +0000 Original-Received: from localhost ([127.0.0.1]:44563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmyWT-0001JP-Hl for submit@debbugs.gnu.org; Fri, 25 Jan 2019 05:15:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmyWR-0001JC-DZ for 34179@debbugs.gnu.org; Fri, 25 Jan 2019 05:15:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmyWD-0007BF-5o; Fri, 25 Jan 2019 05:15:26 -0500 Original-Received: from [176.228.60.248] (port=4779 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gmyW8-0006Ql-8c; Fri, 25 Jan 2019 05:15:22 -0500 In-reply-to: <5C4ADA96.4010400@gmx.at> (message from martin rudalics on Fri, 25 Jan 2019 10:44:54 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154767 Archived-At: > Date: Fri, 25 Jan 2019 10:44:54 +0100 > From: martin rudalics > CC: 34179@debbugs.gnu.org > > >> #0 redisplay_other_windows () at xdisp.c:597 > >> #1 0x010aa09e in select_window (window=XIL(0xa000000006919aa0), > >> norecord=XIL(0x3d36a14), inhibit_point_swap=false) at window.c:540 > >> #2 0x010aa62a in Fselect_window (window=XIL(0xa000000006919aa0), > >> norecord=XIL(0x3d36a14)) at window.c:628 > > > > To clarify: these backtraces show where windows_or_buffers_changed is > > being set to the value of 2, which causes us to retry redisplay. It > > is a direct consequence of the fact that window-max-chars-per-line > > calls select-window. > > If I replace the line > > (with-selected-window (window-normalize-window window t) > > of 'window-max-chars-per-line' by the line > > (with-current-buffer (window-buffer window) > > the problem persists. So it is not the 'select-window' call per se > that causes the trouble. That's because both selecting a window and changing its buffer sets windows_or_buffers_changed via redisplay_other_windows. > The problem is with having that separate frame that gets its echo > area resized. What separate frame? > Using 'window-size-change-functions' (patch attached) instead of > 'window-configuration-change-hook' fixes the problem here. That might be a good change anyway, but the more general problem of having an easily triggered infloop in redisplay_internal remains, and we should fix that, IMO. Let me turn the table and ask: why do we need to retry redisplay when some function called from run_window_change_functions does something that requires redisplay? Why not leave that to the next redisplay cycle?