From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 16 Mar 2019 14:26:36 +0200 Message-ID: <83y35fxawz.fsf@gnu.org> References: <20190312192017.fkfd4h5gsbdue5q3@Ergus> <83imwm3fxf.fsf@gnu.org> <20190313200225.dpqrw7xthkj47fqw@Ergus> <83bm2e35a1.fsf@gnu.org> <20190314030224.l5zseslncw3xc5ox@Ergus> <835zsm2c2s.fsf@gnu.org> <20190314165147.gmtwgzqaibwbzhbm@Ergus> <83r2b91flg.fsf@gnu.org> <20190314211313.giyz7p6jtmquabea@Ergus> <83bm2c1smi.fsf@gnu.org> <20190315205626.4ulamwcaojxnhfu6@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110305"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 13:27:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h58Pp-000SWL-5X for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 13:27:53 +0100 Original-Received: from localhost ([127.0.0.1]:41406 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58Po-00074b-4q for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 08:27:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58Op-000738-R8 for emacs-devel@gnu.org; Sat, 16 Mar 2019 08:26:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h58Op-0006mV-GM; Sat, 16 Mar 2019 08:26:51 -0400 Original-Received: from [176.228.60.248] (port=4663 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h58Oo-0004TY-Ou; Sat, 16 Mar 2019 08:26:51 -0400 In-reply-to: <20190315205626.4ulamwcaojxnhfu6@Ergus> (message from Ergus on Fri, 15 Mar 2019 21:56:26 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234208 Archived-At: > Date: Fri, 15 Mar 2019 21:56:26 +0100 > From: Ergus > Cc: emacs-devel@gnu.org > > Anyway I think the discussion in progress can give a different answer. I > will wait a bit more to get a recommendation. Or a solution that promise > to be better. OK, we are waiting for your legal paperwork anyway. > >One more potential issue that I think you should test is when the > >fringes are disabled on GUI frames, and we usurp the last column of > >the text area to display continuation and truncation glyphs there, as > >we do on TTY frames. If the fill-column is equal to the last column > >of the window, or to one before the last, I think you will need to > >augment your comparison with it->last_visible_x in this case. > > > The code that adds the information looks to run later, so the line is > hidden in that case, which for me is the expected behavior. Otherwise I > didn't understand the issue. My concern was that it->last_visible_x is not the last pixel you can use for the indicator, because there must be space left for the continuation and truncation glyphs. But if you tested that use case and the code works, I'm happy. > In graphical interfaces the space after the line is always filled with > the background color of the face of the last produced glyph, even if I > reset it to the saved value after the generation. The only solution I > found so far was to add an extra glyph after reset the face to the > default (saved) value, but hopefully there is a better way? I don't think I understand what face is "the face of the last produced glyph". is that the face of the indicator character, is that the default face, or is that something else? Can you show a screenshot?