From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33016: 26.1; (make-process ...) doesn't signal an error, when executable given as absolute Windows path does not exist Date: Mon, 08 Apr 2019 21:58:58 +0300 Message-ID: <83y34k728d.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149820"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33016@debbugs.gnu.org, bauer.klaus.dieter@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 08 21:00:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDZV8-000cr9-5s for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 21:00:14 +0200 Original-Received: from localhost ([127.0.0.1]:57471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDZV7-0000lX-8R for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 15:00:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDZUy-0000l0-TA for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 15:00:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDZUx-00054R-Sw for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 15:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36639) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDZUx-00054J-Lj for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 15:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDZUx-0002vr-6b for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 15:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2019 19:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33016 X-GNU-PR-Package: emacs Original-Received: via spool by 33016-submit@debbugs.gnu.org id=B33016.155474996011189 (code B ref 33016); Mon, 08 Apr 2019 19:00:03 +0000 Original-Received: (at 33016) by debbugs.gnu.org; 8 Apr 2019 18:59:20 +0000 Original-Received: from localhost ([127.0.0.1]:50183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDZUG-0002uP-2y for submit@debbugs.gnu.org; Mon, 08 Apr 2019 14:59:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDZUD-0002uA-VD for 33016@debbugs.gnu.org; Mon, 08 Apr 2019 14:59:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDZU8-0003os-Dj; Mon, 08 Apr 2019 14:59:12 -0400 Original-Received: from [176.228.60.248] (port=2931 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hDZU5-0006kJ-QU; Mon, 08 Apr 2019 14:59:11 -0400 In-reply-to: (message from Noam Postavsky on Mon, 8 Apr 2019 14:34:41 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157357 Archived-At: > From: Noam Postavsky > Date: Mon, 8 Apr 2019 14:34:41 -0400 > Cc: 33016@debbugs.gnu.org > > > M-x eval-expression RET > > (make-process :name "test" :command '("c:/No Such Command")) > > > > will merely display in the echo-area message: > > > > eval: Spawning child process: Invalid argument > > The confusing thing here is that the error is signaled between > block_input()...unblock_input(), which prevents the debugger from > triggering. E.g., the "-unless-debug" part in the expression below > appears not to work, even though the error flows normally in other > respects: > > (condition-case-unless-debug err > (make-process :name "test" :command '("c:/No Such Command")) > (error (list :error err))) > ;=> (:error (file-error "Spawning child process" "Invalid argument")) > > The attached patch fixes this by moving the signal to after the unblock_input(). Thanks, but could we have a test for this, please?