From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Sun, 21 Apr 2019 22:03:07 +0300 Message-ID: <83y34389lg.fsf@gnu.org> References: <87sh806xwa.fsf@chapu.is> <83r2awnw0w.fsf@gnu.org> <83d0mgnn31.fsf@gnu.org> <835zs7och6.fsf@gnu.org> <83tvfqnbxc.fsf@gnu.org> <83lg12n75s.fsf@gnu.org> <83h8bqn2ik.fsf@gnu.org> <83zhphliil.fsf@gnu.org> <181b93a3-3861-0481-1b95-8344410d1049@yandex.ru> <83r2a2hdxn.fsf@gnu.org> <21f68973-a684-2a65-82eb-c8f3df90127f@yandex.ru> <83d0lmgez2.fsf@gnu.org> <7d503be9-4d85-3d0b-6829-631ad376ba3d@yandex.ru> <831s22gcci.fsf@gnu.org> <83y349gasn.fsf@gnu.org> <83d0lfag4x.fsf@gnu.org> <5cf45a21-65c3-67ee-f123-be83a6ee7c99@yandex.ru> <83a7gjaen6.fsf@gnu.org> <837ebnabkf.fsf@gnu.org> <83zhoj8shg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86237"; mail-complaints-to="usenet@blaine.gmane.org" Cc: sebastien@chapu.is, dgutov@yandex.ru, 31138@debbugs.gnu.org To: yyoncho Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 21 21:04:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIHl6-000MG6-2C for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2019 21:04:12 +0200 Original-Received: from localhost ([127.0.0.1]:56123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIHl4-0006AS-VM for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Apr 2019 15:04:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIHky-0006AC-J7 for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 15:04:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIHkx-0000sZ-IW for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 15:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35532) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIHkw-0000s1-1O for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 15:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIHkv-0004J3-OL for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2019 15:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Apr 2019 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.155587342916535 (code B ref 31138); Sun, 21 Apr 2019 19:04:01 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 21 Apr 2019 19:03:49 +0000 Original-Received: from localhost ([127.0.0.1]:49076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIHki-0004Id-Vq for submit@debbugs.gnu.org; Sun, 21 Apr 2019 15:03:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIHkf-0004IM-BB for 31138@debbugs.gnu.org; Sun, 21 Apr 2019 15:03:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIHkZ-0000dt-FP; Sun, 21 Apr 2019 15:03:39 -0400 Original-Received: from [176.228.60.248] (port=3115 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hIHkW-0002ie-Ie; Sun, 21 Apr 2019 15:03:39 -0400 In-reply-to: (message from yyoncho on Sun, 21 Apr 2019 16:28:02 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157957 Archived-At: > From: yyoncho > Date: Sun, 21 Apr 2019 16:28:02 +0300 > Cc: Dmitry Gutov , Sébastien Chapuis , > 31138@debbugs.gnu.org > > The issue here is not that the library is some code not written by the > Emacs project, because we do the same with text generated by Emacs > Lisp programs. Bugs can happen in both external libraries and in code > written by Emacs programmers. > > I am a bit confused, (maybe I am talking nonsense) but if the input is already an emacs lisp string doesn't that > mean that we should not decode it since it is already validated? If the text is multibyte text, yes. But Lisp programs can also generate unibyte text. > But even if we had to convert it, we can do it > once(e. g. apply decode string on the input string) instead of doing that for each string in the JSON and > eventually yield performance improvement? We can do that, yes. I don't know what kind of speedup this will get us, we should measure that. > For a reference, I have compared the performance of read-from-string > with the json equivalent and it is ~3 times faster(if memory serves > me right). read-from-string doesn't decode. You need to time decode-coding-string when the string is the entire JSON.