From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Fixing some warnings in emacs-26
Date: Sat, 08 Jun 2019 11:43:08 +0300 [thread overview]
Message-ID: <83y32co4bn.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0SRntA6BzYRwfhyMfsd5oh0tk54kA=RNkwM_hOpzmDkWWw@mail.gmail.com> (message from Juanma Barranquero on Sat, 8 Jun 2019 09:07:43 +0200)
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 8 Jun 2019 09:07:43 +0200
> Cc: Emacs developers <emacs-devel@gnu.org>
>
> > Instead of the arbitrary value of 20, I'd prefer using sizeof for the
> > actual text (which should probably be assigned to a variable, to avoid
> > mentioning the same text twice).
>
> Done.
>
> Though I wanted to avoid adding complexity for a string message that's
> unlikely to change. Also, addpm.c already contains a few instances of
> hardcoded constants:
>
> /* Ensure there is enough room for "...\GNU Emacs\Emacs.lnk". */
> if (strlen (start_folder) < (MAX_PATH - 20))
>
> and
>
> char add_item[MAX_PATH*2 + 100];
>
> etc.
Feel free to change them as well, although addpm is deprecated, so I
wonder whether we should bother cleaning up purely stylistic issues in
it.
Thanks.
next prev parent reply other threads:[~2019-06-08 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 5:11 Fixing some warnings in emacs-26 Juanma Barranquero
2019-06-08 6:41 ` Eli Zaretskii
2019-06-08 7:07 ` Juanma Barranquero
2019-06-08 8:43 ` Eli Zaretskii [this message]
2019-06-08 22:55 ` Juanma Barranquero
2019-06-09 6:12 ` Eli Zaretskii
2019-06-08 8:22 ` Andreas Schwab
2019-06-08 8:51 ` Eli Zaretskii
2019-06-09 11:02 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y32co4bn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.