From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Gnus nnir patch for Emacs 26? Date: Thu, 13 Jun 2019 13:04:19 +0300 Message-ID: <83y325ztr0.fsf@gnu.org> References: <87tvcuscih.fsf@ericabrahamsen.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109303"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 13 12:12:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbMiG-000SIO-V2 for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 12:12:09 +0200 Original-Received: from localhost ([::1]:38210 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbMiF-0004wA-Ux for ged-emacs-devel@m.gmane.org; Thu, 13 Jun 2019 06:12:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57660) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hbMan-0001YV-6k for emacs-devel@gnu.org; Thu, 13 Jun 2019 06:04:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hbMak-0002P2-Kz; Thu, 13 Jun 2019 06:04:22 -0400 Original-Received: from [176.228.60.248] (port=4118 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hbMai-0000N6-48; Thu, 13 Jun 2019 06:04:20 -0400 In-reply-to: <87tvcuscih.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Wed, 12 Jun 2019 14:46:14 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237493 Archived-At: > From: Eric Abrahamsen > Date: Wed, 12 Jun 2019 14:46:14 -0700 > > Someone recently reported a bug in Gnus for searching IMAP groups when > the group has a non-ascii name. The bug has been there a while, at least > as far back as Emacs 26. I've attached the diff, which looks large only > because of indentation changes, it boils down to adding the line: > > (setq group (nnimap-decode-gnus-group group)) I didn't understand that this change fixes the problem, the last message still indicated the patch didn't resolve it. Did you continue discussing off-list or something? If not, how do you know the fix is complete? > Is it too late/too intrusive for Emacs 26? This is the first time > anyone's reported the bug, so it's obviously not super pressing. Another > odd thing is that this fix will be unnecessary once the > scratch/gnus-decoded branch lands, so this change shouldn't go into > master, but I gather that's possible with a dontmerge cookie or > something. If this patch indeed fixes the problem, it's okay for emacs-26, but please only add that one line, don't reindent anything and don't replace lambda with its fancier equivalent. Just the minimal required change. Thanks.