From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite'
Date: Tue, 02 Jul 2019 19:48:34 +0300
Message-ID: <83y31gcrh9.fsf@gnu.org>
References: <CADwFkmknRXCYxAouO8a3in1REUJkaXjMws50HyUKuJz4h=Vmhw@mail.gmail.com>
 <CADwFkmnCoj5PFBgUWy7iDHXza895gFaOnQ-0=fCQpczeG=i3yQ@mail.gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="45183"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: 25032@debbugs.gnu.org
To: Stefan Kangas <stefan@marxist.se>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 02 21:22:24 2019
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hiOMA-000Bac-OB
	for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 21:22:22 +0200
Original-Received: from localhost ([::1]:56514 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.86_2)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>)
	id 1hiOM9-0001Ig-MF
	for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 15:22:21 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52971)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiLxz-0008V3-Jt
 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:49:16 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiLxs-0006Zm-6S
 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:49:10 -0400
Original-Received: from debbugs.gnu.org ([209.51.188.43]:38975)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hiLxm-0006Hc-5K
 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:49:03 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiLxm-00061K-1q
 for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:49:02 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Tue, 02 Jul 2019 16:49:02 +0000
Resent-Message-ID: <handler.25032.B25032.156208613823133@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 25032
X-GNU-PR-Package: emacs
Original-Received: via spool by 25032-submit@debbugs.gnu.org id=B25032.156208613823133
 (code B ref 25032); Tue, 02 Jul 2019 16:49:02 +0000
Original-Received: (at 25032) by debbugs.gnu.org; 2 Jul 2019 16:48:58 +0000
Original-Received: from localhost ([127.0.0.1]:47796 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1hiLxh-000612-Rd
 for submit@debbugs.gnu.org; Tue, 02 Jul 2019 12:48:58 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:40526)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@gnu.org>) id 1hiLxg-00060o-NE
 for 25032@debbugs.gnu.org; Tue, 02 Jul 2019 12:48:57 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52242)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1hiLxY-0005kB-Vf; Tue, 02 Jul 2019 12:48:50 -0400
Original-Received: from [176.228.60.248] (port=1173 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1hiLxY-0008P4-Cf; Tue, 02 Jul 2019 12:48:48 -0400
In-reply-to: <CADwFkmnCoj5PFBgUWy7iDHXza895gFaOnQ-0=fCQpczeG=i3yQ@mail.gmail.com>
 (message from Stefan Kangas on Tue, 2 Jul 2019 07:27:34 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 209.51.188.43
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org
Original-Sender: "bug-gnu-emacs"
 <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.bugs:161978
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/161978>

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 2 Jul 2019 07:27:34 +0200
> Cc: 25032@debbugs.gnu.org
> 
> +If OVERWRITE-OR-PUSH is nil, then raise an error if there is

We use "signal an error".

> +already a bookmark named NAME; if `overwrite', then replace any
> +existing bookmark if there is one; if `push' then push the new
> +bookmark onto the bookmark alist.

It is generally better to precede a description of several optional
behaviors with a short summary:

  OVERWRITE-OR-PUSH controls what happens if there is already a
  bookmark by that NAME: nil means signal an error, `overwrite' means
  replace the existing bookmark, `push' means ...