From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37153: 26.1; some png images scrambled Date: Sun, 25 Aug 2019 10:24:50 +0300 Message-ID: <83y2zhhflp.fsf@gnu.org> References: <5b006777-5e97-a641-6f93-83a437ca9ca7@cs.ucla.edu> <44134.15891.158963.23904@gargle.gargle.HOWL> <9c4c68ebe20cbcc44763be8e72bd25eb.squirrel@weber.math.s.chiba-u.ac.jp> <83tva6j29w.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110570"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37153@debbugs.gnu.org, eggert@cs.ucla.edu, winkler@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 09:25:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1mtj-000Sea-3G for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 09:25:11 +0200 Original-Received: from localhost ([::1]:41202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1mtg-0005LL-ND for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 03:25:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33226) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1mtb-0005LE-ER for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 03:25:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1mta-0007J8-F5 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 03:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1mta-0007J1-C0 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 03:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1mta-0004cT-4y for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 03:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37153 X-GNU-PR-Package: emacs Original-Received: via spool by 37153-submit@debbugs.gnu.org id=B37153.156671790117747 (code B ref 37153); Sun, 25 Aug 2019 07:25:02 +0000 Original-Received: (at 37153) by debbugs.gnu.org; 25 Aug 2019 07:25:01 +0000 Original-Received: from localhost ([127.0.0.1]:43523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1mtY-0004cB-WA for submit@debbugs.gnu.org; Sun, 25 Aug 2019 03:25:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1mtW-0004bx-Nh for 37153@debbugs.gnu.org; Sun, 25 Aug 2019 03:24:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i1mtQ-0007Fo-EZ; Sun, 25 Aug 2019 03:24:52 -0400 Original-Received: from [176.228.60.248] (port=1846 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i1mtP-0005VK-K7; Sun, 25 Aug 2019 03:24:51 -0400 In-reply-to: (message from YAMAMOTO Mitsuharu on Sun, 25 Aug 2019 13:19:24 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165808 Archived-At: > Date: Sun, 25 Aug 2019 13:19:24 +0900 > From: YAMAMOTO Mitsuharu > Cc: winkler@gnu.org, > 37153@debbugs.gnu.org, > eggert@cs.ucla.edu > > > > --- a/src/image.c > > > +++ b/src/image.c > > > @@ -6680,7 +6680,7 @@ png_load_body (struct frame *f, struct image *img, > > > struct png_load_context *c) > > > /* Create an image and pixmap serving as mask if the PNG image > > > contains an alpha channel. */ > > > if (channels == 4 > > > - && !transparent_p > > > + && transparent_p > > > && !image_create_x_image_and_pixmap (f, img, width, height, 1, > > > &mask_img, 1)) > > > { > > > > > > > That didn't change anything in how I see the image in question, FWIW. > > Attached is a screenshot on X11. Probably W32 needs some more work. I always see the 3rd image, no matter what face is specified, FWIW.