all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: cpitclaudel@gmail.com, theophilusx@gmail.com,
	37517@debbugs.gnu.org, fmdkdd@gmail.com
Subject: bug#37517: New rx.el breaks a number of packages - missing symbol rx-submatch-n
Date: Thu, 26 Sep 2019 13:53:18 +0300	[thread overview]
Message-ID: <83y2ybl469.fsf@gnu.org> (raw)
In-Reply-To: <24516DC3-8F75-4544-800F-FFBBAC977B35@acm.org> (message from Mattias Engdegård on Thu, 26 Sep 2019 12:01:46 +0200)

> From: Mattias Engdegård <mattiase@acm.org>
> Date: Thu, 26 Sep 2019 12:01:46 +0200
> Cc: Clément Pit-Claudel <cpitclaudel@gmail.com>,
>  Tim Cross <theophilusx@gmail.com>, fmdkdd <fmdkdd@gmail.com>
> 
> Thanks for the report. The old rx code was apparently written prior to the double-hyphen convention for marking package-internal symbols, and `rx-submatch-n' is clearly an internal function; I'm not sure why it is used by flycheck.
> 
> Of course we could attempt to implement `rx-submatch-n' and what other internal stuff happen to be used by external packages, but that's an open-ended endeavour. Furthermore, it may not always be possible to replicate the expected semantics (internal variables are particularly difficult in that respect).
> 
> I'd much rather work with package maintainers to promote the use of stable interfaces. What about the attached patch (untested)?

At the very least, this information, including how to emulate
functions you removed, should be in NEWS.  Bonus points for providing
the missing APIs, even if you consider them internal.  The package is
so old that by now we should consider its APIs to be a de-facto
standard.  A re-implementation that claims to be compatible cannot
just toss them.

Thanks.





  reply	other threads:[~2019-09-26 10:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26  1:45 bug#37517: New rx.el breaks a number of packages - missing symbol rx-submatch-n Tim Cross
2019-09-26 10:01 ` Mattias Engdegård
2019-09-26 10:53   ` Eli Zaretskii [this message]
2019-09-26 12:42     ` Mattias Engdegård
2019-09-26 14:28       ` Eli Zaretskii
2019-09-29 12:57         ` Mattias Engdegård
2019-09-29 13:05           ` Eli Zaretskii
2019-09-29 15:07             ` Mattias Engdegård
2019-09-29 15:17               ` Eli Zaretskii
2019-09-26 14:04   ` Clément Pit-Claudel
2019-09-26 14:33     ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y2ybl469.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37517@debbugs.gnu.org \
    --cc=cpitclaudel@gmail.com \
    --cc=fmdkdd@gmail.com \
    --cc=mattiase@acm.org \
    --cc=theophilusx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.