From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38406: 27.0.50; post-self-insert-hook does not hold its contract in cc-mode derived modes Date: Fri, 06 Dec 2019 20:48:26 +0200 Message-ID: <83y2vpffyd.fsf@gnu.org> References: <20191201150738.GB5085@ACM> <83imn0lyed.fsf@gnu.org> <20191201192709.GE5085@ACM> <83blsrn58a.fsf@gnu.org> <20191204204159.GA7587@ACM> <83immuj0g7.fsf@gnu.org> <20191205190951.GA6252@ACM> <83pnh2h8x1.fsf@gnu.org> <20191205201713.GC6252@ACM> <83eexhho8o.fsf@gnu.org> <20191206182842.GA3999@ACM> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="85670"; mail-complaints-to="usenet@blaine.gmane.org" Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 06 19:52:51 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idIig-000MA7-8D for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2019 19:52:50 +0100 Original-Received: from localhost ([::1]:43924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idIie-0000Qj-Vk for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Dec 2019 13:52:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40233) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idIf1-0005kq-Ew for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 13:49:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idIf0-0003qG-5P for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 13:49:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41094) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idIez-0003pB-TT for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 13:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idIez-0007Tm-P7 for bug-gnu-emacs@gnu.org; Fri, 06 Dec 2019 13:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Dec 2019 18:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38406 X-GNU-PR-Package: emacs Original-Received: via spool by 38406-submit@debbugs.gnu.org id=B38406.157565811528672 (code B ref 38406); Fri, 06 Dec 2019 18:49:01 +0000 Original-Received: (at 38406) by debbugs.gnu.org; 6 Dec 2019 18:48:35 +0000 Original-Received: from localhost ([127.0.0.1]:47067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIeZ-0007SO-F3 for submit@debbugs.gnu.org; Fri, 06 Dec 2019 13:48:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIeW-0007S8-TX for 38406@debbugs.gnu.org; Fri, 06 Dec 2019 13:48:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idIeR-0002dY-FL; Fri, 06 Dec 2019 13:48:27 -0500 Original-Received: from [176.228.60.248] (port=1574 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1idIeQ-0005v9-S1; Fri, 06 Dec 2019 13:48:27 -0500 In-reply-to: <20191206182842.GA3999@ACM> (message from Alan Mackenzie on Fri, 6 Dec 2019 18:28:42 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172978 Archived-At: > Date: Fri, 6 Dec 2019 18:28:42 +0000 > Cc: yyoncho@gmail.com, 38406@debbugs.gnu.org > From: Alan Mackenzie > > > There might be a misunderstanding on my part here. Could you please > > explain how come electric-pair-post-self-insert-function is called > > twice if it isn't removed from the hook? where's the second (or the > > first) call? > > The first call is an explicit call from c-electric-brace to > electric-pair-post-self-insert-function. Depending on the changes to the > buffer this call causes (amongst other things), differing electric > actions are performed by c-electric-brace. This call is itself a > workaround, there being no purpose designed function for this purpose in > elec-pair.el. > > The second call happens when c-electric-brace run-hook's > post-self-insert-hook - _if_ electric-pair-post-self-insert-function > hasn't been filtered out of that hook. If you already call that particular function explicitly, then calling it one more time is indeed redundant. But is this the case with all the other functions that you suggest to filter from post-self-insert-hook?