From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52385: 29.0.50; Doc-View can't view separate pages in separate windows Date: Sat, 18 Dec 2021 11:11:34 +0200 Message-ID: <83y24ib7ll.fsf@gnu.org> References: <86wnkbnfnp.fsf@mail.linkov.net> <86ee6c5upv.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29387"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 52385@debbugs.gnu.org To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 18 10:12:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myVlD-0007Vd-9E for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 10:12:11 +0100 Original-Received: from localhost ([::1]:55774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myVlB-0006sc-GT for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 04:12:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43980) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myVl5-0006sM-E2 for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 04:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myVl3-0006vx-TH for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 04:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myVl3-0002dF-Mk for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 04:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Dec 2021 09:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52385 X-GNU-PR-Package: emacs Original-Received: via spool by 52385-submit@debbugs.gnu.org id=B52385.163981871810106 (code B ref 52385); Sat, 18 Dec 2021 09:12:01 +0000 Original-Received: (at 52385) by debbugs.gnu.org; 18 Dec 2021 09:11:58 +0000 Original-Received: from localhost ([127.0.0.1]:41256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myVkz-0002cw-PQ for submit@debbugs.gnu.org; Sat, 18 Dec 2021 04:11:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myVkx-0002cj-ID for 52385@debbugs.gnu.org; Sat, 18 Dec 2021 04:11:56 -0500 Original-Received: from [2001:470:142:3::e] (port=42494 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myVkq-0006v9-S6; Sat, 18 Dec 2021 04:11:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bLabnMKeI6C1PngJopz5wI34U3j595T/pZMcy6rS7fI=; b=mvqBhUkUTnot aFIjEFaZUfSLekyBLmW1/CA2LosKiHJwwAEUYcGF0acbTe2uexPgaorwK0B8vfRWLQ0R9P4owmUPa 24T4QSh4h/3XW2Mc9N9k9NtPtEQ5inOsG1MbPqkKGRIU0Tg2oMKA84FGCC1Pe/wu2ngCeuoW9+8JB GsteHkTzHdPH9Rq+nHhTETIq0QaBJvJiGAI+/OV2Nr3F2TZ1KntINIIhxsv1HFRLzsQf8nwlC7/4w iPfQkE8TgEoIcyDWaGb077TV5jCzqLLn79YiU0VMchmCvEUDkTulTY2oDHo+s4uhACIvpI20IzdD7 wknvcr1or5y5qn6bp23ElQ==; Original-Received: from [87.69.77.57] (port=1143 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myVko-0007rC-QO; Sat, 18 Dec 2021 04:11:47 -0500 In-Reply-To: <86ee6c5upv.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 16 Dec 2021 19:04:12 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222603 Archived-At: > From: Juri Linkov > Date: Thu, 16 Dec 2021 19:04:12 +0200 > Cc: 52385@debbugs.gnu.org > > But the regression is in overlay window priorities: > when two overlays with 'window' properties are added > over the same region, then in 27.2 the overlay where > the overlay window matches the selected window is preferred > over the overlay with another window. But in 28.0.90 > the first overlay always wins. > > Here is the shortest test case: > > (let ((o1 (make-overlay (point-min) (point-max) nil t)) > (o2 (make-overlay (point-min) (point-max) nil t))) > (overlay-put o1 'window (selected-window)) > (overlay-put o1 'display '(image :type xpm :file "left-arrow.xpm")) > (select-window (split-window)) > (overlay-put o2 'window (selected-window)) > (overlay-put o2 'display '(image :type xpm :file "right-arrow.xpm"))) Thanks for the recipe. > In 27.2 it displays different images in different windows. But > in 28.0.90 only one images is displayed in both windows. In fact, the problem existed only in Emacs 29, on the master branch. Emacs 28 behaves correctly. Lars, this happened due to one of the changes you made as part of installing the support for the 'min-width' space display spec: a small code fragment was moved inside handle_display_prop, in a way that disabled the selection of overlays specific to windows, when those overlays have the 'display' property. I moved that code fragment back to where it belongs, and tested that min-width still seems to work, both on the mode line and in the xdisp-tests.el. If you know about any other situation where that move of the code was necessary, please show the recipe or tell the details. Otherwise, this bug should be fixed now on the master branch.