From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55393: describe-keymap: suggest symbol at point Date: Fri, 13 May 2022 15:06:40 +0300 Message-ID: <83y1z5myb3.fsf@gnu.org> References: <87pmki13i2.fsf@gmail.com> <83fslene7p.fsf@gnu.org> <87h75u0wjl.fsf@gmail.com> <83bkw2ncw1.fsf@gnu.org> <87czgh280t.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16790"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55393@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 13 14:37:47 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npUYF-0004Bw-Nl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 14:37:47 +0200 Original-Received: from localhost ([::1]:60096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npUYE-0003E5-OJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 08:37:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npU4U-0005gy-PC for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 08:07:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npU4U-0003n0-E3 for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 08:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npU4U-0005zR-4c for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 08:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 May 2022 12:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55393-submit@debbugs.gnu.org id=B55393.165244360422992 (code B ref 55393); Fri, 13 May 2022 12:07:02 +0000 Original-Received: (at 55393) by debbugs.gnu.org; 13 May 2022 12:06:44 +0000 Original-Received: from localhost ([127.0.0.1]:43069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npU4C-0005ym-CF for submit@debbugs.gnu.org; Fri, 13 May 2022 08:06:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npU4B-0005yT-OO for 55393@debbugs.gnu.org; Fri, 13 May 2022 08:06:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52752) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npU46-0003fL-Fi; Fri, 13 May 2022 08:06:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UTbLPJEALgjKzEpKJPRaOdbXcZXJaLELCOWk8fpbLsM=; b=KN8xzaWSpG1j BNMoXR/Y4q3znAX5FU0p2xw99KUCsgtOM8hsEg5X6Sl3iamJ8ovoAeZhbsfKgrTvGTEQ4T09vnIVI ITlM/6BJ/LINGhyBAY9gFmoYznjFiDFppIre0KS6ezE7IYHJGrhsPImhDG2dsHFOLCZCfW51lA4PB MlIyaa8kfRF80NFLyjdEFpv6A5ol5EiLTou6Zca6DvYGD2b2B2C/rOyE3jgdF5otb1UQDDTJKVpQ1 y1rf66o27IxIxCfFff+xrAndQtDyB911NvJX8W2E4ooRC7vW2QsqgVcG75UIQGsI4TWwsvotTUG4V +rOSkx/ZN82EvxWW5/r9JQ==; Original-Received: from [87.69.77.57] (port=1861 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npU42-0008Je-Q6; Fri, 13 May 2022 08:06:38 -0400 In-Reply-To: <87czgh280t.fsf@gmail.com> (message from Visuwesh on Fri, 13 May 2022 13:12:26 +0530) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232130 Archived-At: > From: Visuwesh > Cc: 55393@debbugs.gnu.org > Date: Fri, 13 May 2022 13:12:26 +0530 > > >> The 'interactive' form of describe-keymap uses this function. I don't > >> see this function being used anywhere else either. > > > > Nothing prevents future reuse of the subroutine in another place. I > > would prefer to have this code directly in the interactive form, to be > > more future-proof. And note that the if-let form's result is not used > > in any way in the rest of the code of that function, which also speaks > > volumes of its being an independent issue. > > Now done, please check. LGTM, thanks. A minor nit: > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -562,6 +562,11 @@ minor modes are listed after the major mode. > The apropos commands will now select the apropos window if > 'help-window-select' is non-nil. > > +--- > +*** 'describe-keymap' now considers the symbol at point. > +'describe-keymap' suggests the symbol at point as the default > +candidate if it is a keymap. That "it" is ambiguous, since it could allude to more than one entity mentioned before it. I suggest to change the order, so that "if it is a keymap" directly follows "symbol at point". Let's wait for a day or two to let others time to comment on this.