From: Eli Zaretskii <eliz@gnu.org>
To: Visuwesh <visuweshm@gmail.com>
Cc: 55393@debbugs.gnu.org
Subject: bug#55393: describe-keymap: suggest symbol at point
Date: Fri, 13 May 2022 15:06:40 +0300 [thread overview]
Message-ID: <83y1z5myb3.fsf@gnu.org> (raw)
In-Reply-To: <87czgh280t.fsf@gmail.com> (message from Visuwesh on Fri, 13 May 2022 13:12:26 +0530)
> From: Visuwesh <visuweshm@gmail.com>
> Cc: 55393@debbugs.gnu.org
> Date: Fri, 13 May 2022 13:12:26 +0530
>
> >> The 'interactive' form of describe-keymap uses this function. I don't
> >> see this function being used anywhere else either.
> >
> > Nothing prevents future reuse of the subroutine in another place. I
> > would prefer to have this code directly in the interactive form, to be
> > more future-proof. And note that the if-let form's result is not used
> > in any way in the rest of the code of that function, which also speaks
> > volumes of its being an independent issue.
>
> Now done, please check.
LGTM, thanks.
A minor nit:
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -562,6 +562,11 @@ minor modes are listed after the major mode.
> The apropos commands will now select the apropos window if
> 'help-window-select' is non-nil.
>
> +---
> +*** 'describe-keymap' now considers the symbol at point.
> +'describe-keymap' suggests the symbol at point as the default
> +candidate if it is a keymap.
That "it" is ambiguous, since it could allude to more than one entity
mentioned before it. I suggest to change the order, so that "if it is
a keymap" directly follows "symbol at point".
Let's wait for a day or two to let others time to comment on this.
next prev parent reply other threads:[~2022-05-13 12:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 4:05 bug#55393: describe-keymap: suggest symbol at point Visuwesh
2022-05-13 5:24 ` Visuwesh
2022-05-13 6:23 ` Eli Zaretskii
2022-05-13 6:35 ` Visuwesh
2022-05-13 6:51 ` Eli Zaretskii
2022-05-13 7:42 ` Visuwesh
2022-05-13 12:06 ` Eli Zaretskii [this message]
2022-05-13 12:47 ` Visuwesh
2022-05-15 5:26 ` Eli Zaretskii
2022-05-15 5:48 ` Visuwesh
2022-05-15 6:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1z5myb3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55393@debbugs.gnu.org \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.