all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kai Ma <justksqsf@gmail.com>, Yuan Fu <casouri@gmail.com>
Cc: 59807@debbugs.gnu.org
Subject: bug#59807: 29.0.60; [PATCH] python-ts-mode does not auto-complete the closing quote
Date: Sun, 04 Dec 2022 09:19:27 +0200	[thread overview]
Message-ID: <83y1rnbpq8.fsf@gnu.org> (raw)
In-Reply-To: <m21qpgazsp.fsf@gmail.com> (message from Kai Ma on Sun, 04 Dec 2022 06:27:18 +0800)

> From: Kai Ma <justksqsf@gmail.com>
> Date: Sun, 04 Dec 2022 06:27:18 +0800
> 
> When electric-pair-mode is enabled, a single quote ' should be auto
> completed to be '' (which means an empty string).  Python-mode correctly
> does this, but python-ts-mode does not.  This is clearly a problem
> regarding the syntax table.
> 
> The attached patch makes python-ts-mode uses the same syntax table as
> python-mode's, and fixes this problem.  I also checked a few other ts
> modes, and some also have this issue.  For example, js-ts-mode does not
> auto complete '' either, which is also fixed by this patch.
> 
> >From 7f996826bc47bcdd155eb0cc220a48c32cb2619a Mon Sep 17 00:00:00 2001
> From: Kai Ma <justksqsf@gmail.com>
> Date: Sun, 4 Dec 2022 06:15:42 +0800
> Subject: [PATCH] Fix syntax tables of tree-sitter modes
> 
> Tree-sitter modes should use the same syntax table as the
> non-tree-sitter ones.
> * lisp/progmodes/csharp-mode.el (csharp-mode-syntax-table)
> (csharp-mode):
> * lisp/progmodes/js.el (js-mode-syntax-table) (js-ts-mode):
> * lisp/progmodes/python.el (python-ts-mode):
> * lisp/progmodes/sh-script.el (bash-ts-mode):
> * lisp/textmodes/css-mode.el (css-ts-mode):

Thanks, but please format the log message according to our conventions:
there should be a description of the actual changes after the last colon.

Yuan, is it really true that the syntax tables in treesit-supported modes
should be always identical to those of the non-treesit modes?  Or maybe
there could be subtle differences?





  reply	other threads:[~2022-12-04  7:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-03 22:27 bug#59807: 29.0.60; [PATCH] python-ts-mode does not auto-complete the closing quote Kai Ma
2022-12-04  7:19 ` Eli Zaretskii [this message]
2022-12-04  7:28   ` Yuan Fu
2022-12-04  8:07     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-04 12:32   ` Kai Ma
2022-12-05  6:28 ` Yuan Fu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-05  6:48   ` Kai Ma
2022-12-13  1:20     ` Kai Ma
2022-12-13  2:24       ` Stefan Kangas
2022-12-13  5:28         ` Yuan Fu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-13 12:17       ` Eli Zaretskii
2022-12-05  8:22   ` Eli Zaretskii
2022-12-14  2:08 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1rnbpq8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59807@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=justksqsf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.