From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60334: [PATCH] whitespace: Use `define-globalized-minor-mode' for global mode Date: Sat, 31 Dec 2022 10:20:34 +0200 Message-ID: <83y1qo3rxp.fsf@gnu.org> References: <50112124-7212-f1fb-de07-c17cec28e7b6@rhansen.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="591"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60334@debbugs.gnu.org To: Richard Hansen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 31 09:21:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBX7L-000AVT-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Dec 2022 09:21:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBX71-0007ar-Sk; Sat, 31 Dec 2022 03:21:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBX70-0007aU-J7 for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 03:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBX70-0007Rl-76 for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 03:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBX6z-00048O-Vk for bug-gnu-emacs@gnu.org; Sat, 31 Dec 2022 03:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Dec 2022 08:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60334-submit@debbugs.gnu.org id=B60334.167247484215851 (code B ref 60334); Sat, 31 Dec 2022 08:21:01 +0000 Original-Received: (at 60334) by debbugs.gnu.org; 31 Dec 2022 08:20:42 +0000 Original-Received: from localhost ([127.0.0.1]:36517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBX6g-00047b-HP for submit@debbugs.gnu.org; Sat, 31 Dec 2022 03:20:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBX6e-00047O-N3 for 60334@debbugs.gnu.org; Sat, 31 Dec 2022 03:20:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBX6Y-0007K9-EH; Sat, 31 Dec 2022 03:20:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E+cNsZAIui0iPwl8OE1M2BJefPH9cYtEmK0+n4I2g2k=; b=sNN7nBywLTGY qyGafw1CaRc98RvPZM3WqmhhxoVBUxSt9HxrB0TiZKaETGxn+rrlcz+YXXO2MNNXtP2pyvjFfMToq pNjftzeX/AyKJ6uWHflcY70eG4gfdhRKbDUkME2Bov5u5a/L1WLKxcr0trHcsIyHfzHtaKGD+1+Vy kyrVnZQfYTFf0EoJMIMWEZqI31QTgMZrDcC5ZYVqGCdtksaXzVJWrC4wmo/O4Mf2LiOftlpafrp/n yWQTKkyy0M63f3eMfo2yXs0Uwb1S4xBKzcNkE2AXBDzFOknSRvXSLTuQZBRPa43sxdaOdZg+HlMpp Fn/kaanNtnl2NgEMjQBwag==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBX6W-0006Cj-B6; Sat, 31 Dec 2022 03:20:34 -0500 In-Reply-To: <50112124-7212-f1fb-de07-c17cec28e7b6@rhansen.org> (message from Richard Hansen on Mon, 26 Dec 2022 01:32:20 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252171 Archived-At: > Date: Mon, 26 Dec 2022 01:32:20 -0500 > From: Richard Hansen > > Attached patch: > > whitespace: Use `define-globalized-minor-mode' for global mode > > * lisp/whitespace.el (global-whitespace-mode): Fix interoperability > between `whitespace-mode' and `global-whitespace-mode' by using > `define-globalized-minor-mode'. > * test/lisp/whitespace-tests.el (whitespace-tests--global): Add a > regression test. > > It would be nice to install this on emacs-29, but I'm OK with this going > on master. I tried to install this on master (it's too late for such changes on the emacs-29 branch), but the patch failed to apply. Could you please rebase this on master and resubmit? Thanks.