From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Fri, 17 Mar 2023 18:47:28 +0200 Message-ID: <83y1nvcokf.fsf@gnu.org> References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> <875yb1pxai.fsf@miha-pc> <87ttykj45i.fsf@gmx.de> <878rfw51mh.fsf@gmail.com> <87pm98iw1e.fsf@gmx.de> <87fsa43f36.fsf@gmail.com> <87sfe4eh09.fsf@gmx.de> <87wn3g1ssd.fsf@gmail.com> <87zg8co0n0.fsf@miha-pc> <875yaziax4.fsf@miha-pc> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3069"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, joaotavora@gmail.com, 62194@debbugs.gnu.org To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 17 17:48:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdDFS-0000YS-7e for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Mar 2023 17:48:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdDFL-0000yp-Nd; Fri, 17 Mar 2023 12:48:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDFK-0000yh-9p for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 12:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdDFJ-0008JE-Uv for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 12:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdDFJ-0005pI-Mk for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 12:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2023 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.167907165622229 (code B ref 62194); Fri, 17 Mar 2023 16:48:01 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 17 Mar 2023 16:47:36 +0000 Original-Received: from localhost ([127.0.0.1]:45493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdDEt-0005mQ-Eb for submit@debbugs.gnu.org; Fri, 17 Mar 2023 12:47:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdDEr-0005m5-GA for 62194@debbugs.gnu.org; Fri, 17 Mar 2023 12:47:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDEl-0007zW-NZ; Fri, 17 Mar 2023 12:47:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y+NYl+EEEqAuDotz9rKpkoUUaIyPwhiiZYH48rhBV2o=; b=hCGjjBj8wzDU DqVM18rAlY2RXHzQpdfwjYr/ck2BuDdL0meVvVK2TWGk2pofU/zuaNKnA/JNUSXOMCsVVqj48L83g vkI9lVh92uH+xlPBJhHqxFtWTikTZKUMGepwAaLpFFs9Jr7w8QukMuddFE+BjAcaeYQ2x3Jp3mU64 Ns+fruKJkC0rC7imB1xgnt8q5m5ehliSgqUwg79jNGnQpBsoErN3XGlX7j4a/fFZ7ikF9uRIZNB/Y +sCJeJFKtevnIchoXxy5ld93oSlsk5N1yBtHMmBQPWTjT/lwr8/oQ4HQ31wI4AvWubfrTFIYnjEEn 6FIng/qWXgifR8l7uSjDYw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDEl-0007xH-4M; Fri, 17 Mar 2023 12:47:27 -0400 In-Reply-To: <875yaziax4.fsf@miha-pc> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258095 Archived-At: > Cc: Michael Albinus , 62194@debbugs.gnu.org > Date: Fri, 17 Mar 2023 17:45:43 +0100 > From: miha--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Though I do think that if a function that calls a-p-o with > JUST-THIS-ONE=nil isn't internal, it should mention that it can run > timers in its doc string. I don't see why: timers can run in Emacs almost anywhere, so mentioning that in doc strings of every function makes little sense. > But here we are talking about 'expand-file-name' and other functions > from tramp-sh-file-name-handler. For these, I disagree that we want them > to accept output from other processes and call their filters. > 'expand-file-name' and others are used often and, for most of the > existence of Emacs, they did not call proc filters. I think it's > dangerous to have them do it now. Process filters can be also called at any time, because they basically depend on when the output from a subprocess arrives. Why would you want that to stop while Emacs processes expand-file-name? > 'expand-file-name' is synchronous, therefore tramp has to make it use > accept-process-filter (tell me if there's another way). It can use it in > roughly two ways: with JUST-THIS-ONE=t or JUST-THIS-ONE=nil. In the > first case, we hit the eglot-over-ssh freeze problem and in the second > case, we'll have 'expand-file-name' call timers and process filters, > which I explained above why I don't like. I think you should teach yourself to like that.