all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: <miha@kamnitnik.top>
Cc: michael.albinus@gmx.de, joaotavora@gmail.com, 62194@debbugs.gnu.org
Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29
Date: Fri, 17 Mar 2023 18:47:28 +0200	[thread overview]
Message-ID: <83y1nvcokf.fsf@gnu.org> (raw)
In-Reply-To: <875yaziax4.fsf@miha-pc> (bug-gnu-emacs@gnu.org)

> Cc: Michael Albinus <michael.albinus@gmx.de>, 62194@debbugs.gnu.org
> Date: Fri, 17 Mar 2023 17:45:43 +0100
> From: miha--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Though I do think that if a function that calls a-p-o with
> JUST-THIS-ONE=nil isn't internal, it should mention that it can run
> timers in its doc string.

I don't see why: timers can run in Emacs almost anywhere, so
mentioning that in doc strings of every function makes little sense.

> But here we are talking about 'expand-file-name' and other functions
> from tramp-sh-file-name-handler. For these, I disagree that we want them
> to accept output from other processes and call their filters.
> 'expand-file-name' and others are used often and, for most of the
> existence of Emacs, they did not call proc filters. I think it's
> dangerous to have them do it now.

Process filters can be also called at any time, because they basically
depend on when the output from a subprocess arrives.  Why would you
want that to stop while Emacs processes expand-file-name?

> 'expand-file-name' is synchronous, therefore tramp has to make it use
> accept-process-filter (tell me if there's another way). It can use it in
> roughly two ways: with JUST-THIS-ONE=t or JUST-THIS-ONE=nil. In the
> first case, we hit the eglot-over-ssh freeze problem and in the second
> case, we'll have 'expand-file-name' call timers and process filters,
> which I explained above why I don't like.

I think you should teach yourself to like that.





  reply	other threads:[~2023-03-17 16:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 23:08 bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 João Távora
2023-03-15  9:40 ` Michael Albinus
2023-03-15 11:45   ` Michael Albinus
2023-03-15 20:24     ` João Távora
2023-03-15 20:36     ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-15 20:45       ` João Távora
2023-03-16 12:02         ` Michael Albinus
2023-03-16 12:20           ` João Távora
2023-03-16 14:57             ` Michael Albinus
2023-03-16 15:12               ` João Távora
2023-03-16 17:35                 ` Michael Albinus
2023-03-16 17:59                   ` João Távora
2023-03-16 21:18                     ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-16 21:57                       ` João Távora
2023-03-16 23:38                         ` João Távora
2023-03-17 16:45                         ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 16:47                           ` Eli Zaretskii [this message]
2023-03-17 17:22                             ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 17:22                               ` Eli Zaretskii
2023-03-17 10:44                     ` Michael Albinus
2023-03-17 11:19                       ` João Távora
2023-03-18  9:38                         ` Michael Albinus
2023-03-18 11:29                           ` João Távora
2023-03-18 12:23                             ` Michael Albinus
2023-03-18 12:33                               ` João Távora
2023-03-19 12:19                           ` Michael Albinus
2023-03-15 20:16   ` João Távora
2023-03-16 15:02     ` Michael Albinus
2023-03-28 10:51       ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1nvcokf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=62194@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=michael.albinus@gmx.de \
    --cc=miha@kamnitnik.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.