From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background Date: Sat, 01 Apr 2023 09:35:16 +0300 Message-ID: <83y1ncyusb.fsf@gnu.org> References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62556@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 01 08:36:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piUqc-0001ie-LK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Apr 2023 08:36:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piUqL-0000mS-7Q; Sat, 01 Apr 2023 02:36:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUqJ-0000mA-7G for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 02:36:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piUqI-0004X4-JR for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 02:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1piUqH-0000Zo-Vq for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 02:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2023 06:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62556 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62556-submit@debbugs.gnu.org id=B62556.16803309102152 (code B ref 62556); Sat, 01 Apr 2023 06:36:01 +0000 Original-Received: (at 62556) by debbugs.gnu.org; 1 Apr 2023 06:35:10 +0000 Original-Received: from localhost ([127.0.0.1]:35295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUpS-0000Ye-11 for submit@debbugs.gnu.org; Sat, 01 Apr 2023 02:35:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUpQ-0000YN-KK for 62556@debbugs.gnu.org; Sat, 01 Apr 2023 02:35:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUpL-0004BC-4q; Sat, 01 Apr 2023 02:35:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=areD4jInBDwjm9MU0ohxUW6BjWU+Lb0iU5nHQuPZiNU=; b=BgaR/egeO/xa fo0jyoGmHTSC8Afg+8NQuBrta3twqIrPY6jGRriuVY3SRJoWqkx+OO1paWk+SeMK1NXAsbHXP4FoK +m7z84VdD/2Xk7rS9nSH3QpSfWI4TzByE/OG3/InkmTbtIu/V8aky8n0tks/ZwSUdcKKFxBDPgut0 FOvi0rHGfpT/IRcpWn5LDHFfI0U3aYAwOF0i07mElCpU7ojMWMbCJmarP+OSmOvJMVodvzjJSOslS wymUFrm/radQ9NH20VR7LHN14YDnxyxdpFHpEX7hIRC5WwL1Y89a3E9pGSVE9e2Mcwf6ys3V4B0f3 WDv+oTs00aZvxMajVGFo5Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUpI-0001lx-S4; Sat, 01 Apr 2023 02:35:02 -0400 In-Reply-To: <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> (message from Jim Porter on Fri, 31 Mar 2023 13:09:24 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259030 Archived-At: > Date: Fri, 31 Mar 2023 13:09:24 -0700 > Cc: 62556@debbugs.gnu.org > From: Jim Porter > > Thanks. Merged to emacs-29 as 6419d78fa6f. Some of the new tests (and one old as well) fail on MS-Windows: 3 unexpected results: FAILED eshell-test/eshell-command/background FAILED eshell-test/eshell-command/background-pipeline FAILED eshell-test/subcommand-reset-in-pipeline I fixed the first 2, but I don't understand what goes wrong in the last one and why: Test eshell-test/subcommand-reset-in-pipeline backtrace: signal(ert-test-failed (((should (eshell-command-result--equal comma ert-fail(((should (eshell-command-result--equal command (eshell-test (if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de (let (form-description-9) (if (unwind-protect (setq value-7 (apply f (let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti (let* ((fn-5 #'eshell-command-result--equal) (args-6 (condition-case eshell-command-result-equal("*cat $ | * (closure (t) nil (let* ((fn-31 #'executable-find) (args-32 (conditio ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name eshell-test/subcommand-reset-in-pipel ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/eshell/eshell-tests. command-line() normal-top-level() Test eshell-test/subcommand-reset-in-pipeline condition: (ert-test-failed ((should (eshell-command-result--equal command (eshell-test-command-result command) result)) :form (eshell-command-result--equal "*cat $ | *cat" nil "first") :value nil :explanation (nonequal-result (command "*cat $ | *cat") (result nil) (expected "first")))) FAILED 16/16 eshell-test/subcommand-reset-in-pipeline (1.796875 sec) at lisp/eshell/eshell-tests.el:80 The test that fails is this one: (eshell-command-result-equal (format template "echo $eshell-in-pipeline-p | echo") "first") when it is run for the last template, "*cat $<%s> | *cat". As another annoyance, I get this prompt, and must type "yes RET": passed 1/16 eshell-test/command-running-p (0.203125 sec) passed 2/16 eshell-test/eshell-command/background (0.015625 sec) Buffer "*Eshell Async Command Output*" has a running process; kill it? (yes or no) yes passed 3/16 eshell-test/eshell-command/background-pipeline (2.453125 sec) Any suggestions?