From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it Date: Sat, 15 Apr 2023 12:28:47 +0300 Message-ID: <83y1mtcx4g.fsf@gnu.org> References: <2029306.bkXEbi1Pq8@ravel> <12836994.tY86fQioq2@ravel> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28454"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62693@debbugs.gnu.org, ocert.dev@free.fr To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 15 11:29:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pncDi-0007Az-7r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Apr 2023 11:29:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pncDQ-0000JW-6J; Sat, 15 Apr 2023 05:29:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pncDO-0000JO-Rc for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 05:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pncDO-0003h1-GX for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 05:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pncDO-0004I1-25 for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 05:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 09:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62693 X-GNU-PR-Package: emacs Original-Received: via spool by 62693-submit@debbugs.gnu.org id=B62693.168155093516476 (code B ref 62693); Sat, 15 Apr 2023 09:29:02 +0000 Original-Received: (at 62693) by debbugs.gnu.org; 15 Apr 2023 09:28:55 +0000 Original-Received: from localhost ([127.0.0.1]:48253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pncDH-0004Hg-H5 for submit@debbugs.gnu.org; Sat, 15 Apr 2023 05:28:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pncDE-0004HS-T3 for 62693@debbugs.gnu.org; Sat, 15 Apr 2023 05:28:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pncD8-0003fp-JD; Sat, 15 Apr 2023 05:28:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nx29H5jQBr9YW9uztcQD69+ayLQiDhvSSsqB2g0cRxI=; b=Xp6KCQTY3UuN SW+XXgH2q1RW8sr6bc13lMd0vx6rn/Q+KC1TpD1P6oZk/NwLaVscESQ5ENiNcrCJxHSponat8ws2/ k3cvfZ3AS+j6QU835B10WDlIPSz7Ti5R8f7vjuv9v73gICN4BMXV0rc9AkvlQ8ctP+ZcU/aHa9QaC ATTzCG5c2/QC3MD0LweeWREVDDMiVE81gtGXsow9YuCLIFPAni+B61da0H7X13SAxxJ179i8Oydlu voNFTXN6XJjtF5j2x9033FXD7UOv/fltd5GlQsOCrmQJNWivF0+rv1OmNlD++9MP1Xkeie3idZ1BI 9tSK+KFybF/sxJPiGHavrg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pncD8-0007Rr-6y; Sat, 15 Apr 2023 05:28:46 -0400 In-Reply-To: (message from Dmitry Gutov on Sat, 15 Apr 2023 01:59:28 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260010 Archived-At: > Date: Sat, 15 Apr 2023 01:59:28 +0300 > Cc: 62693@debbugs.gnu.org > From: Dmitry Gutov > > On 13/04/2023 19:40, Olivier Certner wrote: > > Hi, > > > > Thanks for looking at this. > > > >> - Could you explain what kind of files are not listed and when? I'm > >> guessing this has to do with the file name? I've tried to reproduce the > >> problem with a file name that contained a space, and couldn't see it. > > > > It's not that files are not listed, they are so always. As said, the problem > > is their name. For example, if I remove an INSTALL file in a repository, > > `INSTALL' is the name listed in a VC dir buffer, *quotes included*. Then, no > > VC operation can work because there is indeed no file by this name (with > > quotes, both in the filesystem or known by CVS). > > So the actual file name is not the problem -- the problem happens with > removed files? > > Okay, I can see that now: when the file is removed, it's displayed > (incorrectly) with quotes around its name. Patches 2 and 3 do fix the > remove - vc-dir - vc-revert scenario. > > Eli, do we want these fixes in emacs-29? These are again not > regressions, but I'm guessing users of CVS are foremost to benefit from > adding this to the upcoming release. The patch is AFAICS basically a complete rewrite of an important function, so I don't see how I could agree applying this to the release branch. Sorry. (Was the introduction of so many CL-isms really necessary, btw?) As a minor nit, please don't use "path" or "PATH" for anything except $PATH-style lists of directories, as GNU Coding Standards frown on such use of this word. We use "file name" or "directory name" or "leading directories" (as the case may be) instead. > Regarding the new patch, it's great to see the list of examples, but > could you instead move it to a test or several inside > test/lisp/vc/vc-cvs-tests.el? This file does not exist yet, but you can > use vc-git-test.el as an example, in the same directory. Yes, having a test for this would be most welcome.