From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62164: 29.0.60; ediff behaves poorly by default on tiling window managers Date: Tue, 06 Jun 2023 14:29:10 +0300 Message-ID: <83y1kw3k3d.fsf@gnu.org> References: <87cz5c87xg.fsf@yahoo.com> <878rg087v5.fsf@yahoo.com> <87a60c3zuc.fsf@yahoo.com> <871ql3nj6y.fsf@catern.com> <871ql2su9q.fsf@yahoo.com> <87v8iemsbh.fsf@catern.com> <83ild19uzd.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, sbaugh@catern.com, 62164@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 06 13:30:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6UtG-0001v2-P5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Jun 2023 13:30:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6Ut1-0001Lp-Pb; Tue, 06 Jun 2023 07:30:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Ut1-0001Lc-40 for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 07:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6Ut0-0005Rx-Qy for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 07:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6Ut0-0004lv-D9 for bug-gnu-emacs@gnu.org; Tue, 06 Jun 2023 07:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Jun 2023 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62164 X-GNU-PR-Package: emacs Original-Received: via spool by 62164-submit@debbugs.gnu.org id=B62164.168605097318281 (code B ref 62164); Tue, 06 Jun 2023 11:30:02 +0000 Original-Received: (at 62164) by debbugs.gnu.org; 6 Jun 2023 11:29:33 +0000 Original-Received: from localhost ([127.0.0.1]:51075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6UsW-0004kn-Vj for submit@debbugs.gnu.org; Tue, 06 Jun 2023 07:29:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6UsU-0004kY-F2 for 62164@debbugs.gnu.org; Tue, 06 Jun 2023 07:29:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6UsO-0005F5-Kx; Tue, 06 Jun 2023 07:29:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OFTGy1n/CFRvfWV3+hf/wNbV+RyfAcejNxvIrpuxCoA=; b=j+cTa86V2/db foDekl2K4mkjcxycvDL4d7Eh2Ws0WhgYDxelrsdNcyTZ9ZZiIRoQSOSIlzlvLU5E6D61rjpOyRZKs FyiPsINgjj78QVjg/9HZ5O+VgJq438Vfp39NaH4zXyAved1EW2NdlMzC/wjoudi4mhBT30+s96byW 1woYVF145VQ0D+mThPF13dzf6MST2SWAp1AF4eaWPiB5/nYI/TxSHNm7KSYHvknIV2zbBrpP0gb7Q U/HKKDk8WvbLIox4MmUQhvtjSkLUT9iSX4SB6c5hDRwqt+sChztbnrF4Mwqt5KvUJcYi6WhO44HKy vVqkYXuF7fVaCCrzxKT/fQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6UsC-0002Yy-AF; Tue, 06 Jun 2023 07:29:23 -0400 In-Reply-To: (message from Spencer Baugh on Mon, 05 Jun 2023 17:56:38 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263049 Archived-At: > From: Spencer Baugh > Cc: luangruo@yahoo.com, sbaugh@catern.com, 62164@debbugs.gnu.org > Date: Mon, 05 Jun 2023 17:56:38 -0400 > > Eli Zaretskii writes: > >> Cc: Po Lu , 62164@debbugs.gnu.org > >> From: Spencer Baugh > >> Date: Tue, 09 May 2023 14:27:11 -0400 > >> > >> +(defcustom ediff-x-utility-control-frame nil > >> + "If non-nil, the control frame is a utility window under X. > >> + > >> +This is useful in tiling window managers, where this will cause > >> +the control frame to be floating rather than tiled. It should be > >> +harmless on other well-behaved window managers." > > > > If this option causes the control frame to be floating rather than > > tiled, the name of the option should reflect that. Using "utility" in > > the name of the variable makes the option less self-explanatory, > > because that technical terms is not relevant on the user level. > > > > Thanks. > > Agreed. Revised patch attached: Thanks, but I think the first line of the doc string should also be modified to explain better what the option does. The rest of the doc string could then mention "utility window", if doing so will help someone to understand what happens and why. But the first line should be a concise summary, because the various apropos commands show only that one line. > (modify-frame-parameters ctl-frame adjusted-parameters) > + (when (and ediff-x-floating-control-frame (eq window-system 'x)) > + (ediff-frame-make-utility ctl-frame)) ^^^^^^^^^^^^^ I think it is better to use window-system the function here, since you are talking about a specific frame.