From: Eli Zaretskii <eliz@gnu.org>
To: Vincenzo Pupillo <v.pupillo@gmail.com>,
Theodor Thornhill <theo@thornhill.no>,
Jostein Kjonigsen <jostein@kjonigsen.net>
Cc: 64647@debbugs.gnu.org
Subject: bug#64647: treesit-query-error due to a recent change to tree-sitter-javascript grammar definition
Date: Sat, 15 Jul 2023 15:57:46 +0300 [thread overview]
Message-ID: <83y1jhbad1.fsf@gnu.org> (raw)
In-Reply-To: <2171209.irdbgypaU6@fedora> (message from Vincenzo Pupillo on Sat, 15 Jul 2023 14:34:29 +0200)
> From: Vincenzo Pupillo <v.pupillo@gmail.com>
> Date: Sat, 15 Jul 2023 14:34:29 +0200
>
> this commit (bb1f97b643b77fc1f082d621bf533b4b14cf0c30) changed the definition
> of the JSX grammar to tree-sitter-javascript. This causes a node type error:
> "
> Error while displaying: (jit-lock-function 1) reported (treesit-query-error
> "Node type error at" 24 "(jsx_opening_element [(nested_identifier (identifier))
> (identifier)] @font-lock-function-call-face) (jsx_closing_element
> [(nested_identifier (identifier)) (identifier)] @font- lock-function-call-face)
> (jsx_self_closing_element [(nested_identifier (identifier)) (identifier)] @font-
> lock-function-call-face) (jsx_attribute (property_identifier) @font-lock-
> constant-face)" "Debug the query with `treesit-query-validate'")
> "
> Indentation also has problems due to the deletion of "jsx_fragment" definition.
>
> The patch in attachment fixes both problems.
Will the patch work with the grammar libraries before the recent
change?
> p.s. nvim-treesitter tries to limit these problems by indicating which commit
> to install. Does it make sense to try a similar approach with emacs as well?
I think it is better if we make the code work with as many versions as
possible, by checking whether a feature exists before using it.
Theo, Jostein: any comments or ideas?
Thanks.
next prev parent reply other threads:[~2023-07-15 12:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 12:34 bug#64647: treesit-query-error due to a recent change to tree-sitter-javascript grammar definition Vincenzo Pupillo
2023-07-15 12:57 ` Eli Zaretskii [this message]
2023-07-15 13:23 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 17:54 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 19:16 ` Eli Zaretskii
2023-07-15 19:39 ` Vincenzo Pupillo
2023-07-15 20:45 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 5:13 ` Eli Zaretskii
2023-07-16 8:38 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-16 18:00 ` Vincenzo Pupillo
2023-07-16 18:19 ` bug#64647: " Eli Zaretskii
2023-07-16 18:56 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-17 21:24 ` Vincenzo Pupillo
2023-07-19 5:11 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-20 10:14 ` Vincenzo Pupillo
2023-07-22 6:41 ` bug#64647: " Eli Zaretskii
2023-07-22 7:29 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-22 8:52 ` Eli Zaretskii
2023-07-22 11:56 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-22 14:10 ` Vincenzo Pupillo
2023-07-22 21:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-22 22:59 ` Yuan Fu
2023-07-23 5:17 ` Eli Zaretskii
2023-07-16 4:48 ` bug#64647: " Eli Zaretskii
2023-07-15 19:17 ` Vincenzo Pupillo
2023-07-15 20:51 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1jhbad1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64647@debbugs.gnu.org \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
--cc=v.pupillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.