From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Date: Sat, 05 Aug 2023 08:43:35 +0300 Message-ID: <83y1iqt56g.fsf@gnu.org> References: <87ttteq2ku.fsf@ledu-giraud.fr> <83il9uvnj3.fsf@gnu.org> <87pm42psv9.fsf@ledu-giraud.fr> <834jlevd7o.fsf@gnu.org> <87r0oied8u.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17219"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65052@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 05 07:44:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSA5N-0004JQ-BP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Aug 2023 07:44:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSA56-0001s9-L5; Sat, 05 Aug 2023 01:44:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSA54-0001lN-Dm for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 01:44:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSA54-0006Zd-07 for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 01:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSA53-0008Gf-Ry for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 01:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 05:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65052 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65052-submit@debbugs.gnu.org id=B65052.169121420931730 (code B ref 65052); Sat, 05 Aug 2023 05:44:01 +0000 Original-Received: (at 65052) by debbugs.gnu.org; 5 Aug 2023 05:43:29 +0000 Original-Received: from localhost ([127.0.0.1]:55233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSA4X-0008Fi-Aj for submit@debbugs.gnu.org; Sat, 05 Aug 2023 01:43:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSA4W-0008FU-0w for 65052@debbugs.gnu.org; Sat, 05 Aug 2023 01:43:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSA4Q-0006D6-2j; Sat, 05 Aug 2023 01:43:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zG20PSfqujhU62U1WQa4Jf8TzW7JNCBx2CafyvdhK90=; b=Uq69Atkp/fw6 /JtGgEHM8VMFzUsIYvPsuwgSau314SYmoGyNxTKrNoO/IuA13CbWSxlapTM8FFvlJqhxbMz0q2Oqp O3BIuIoC7EBC+5NXo29ZABXINEFyXb9RQNSzvovcvCIjD/dfZNRixFFLPxsCujFbjnKjRrfKSjD1W jQJPTzZBPopuIX4L/Bu96L5XmySaRVIXF6RTRMdADiQL44M4yfbGrlh2dHoHOq2xXzR2M29s6n5kU aXUnXbLgL7hbnBKneRgCnqkhKSYkpG6un0j+kU/y+qxii1QVBXakMb7XC4pkuWZK3SSuYS7hUjjiP ExEAJcC3GuHJYv6ZJCoLKg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSA4O-0000z8-K3; Sat, 05 Aug 2023 01:43:21 -0400 In-Reply-To: <87r0oied8u.fsf@ledu-giraud.fr> (message from Manuel Giraud on Fri, 04 Aug 2023 22:58:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266725 Archived-At: > From: Manuel Giraud > Cc: 65052@debbugs.gnu.org > Date: Fri, 04 Aug 2023 22:58:25 +0200 > > Eli Zaretskii writes: > > [...] > > > OK, but then this part: > > > >> + ;; "one line" dance to update tracking and header > >> + (image-dired-next-line) > >> + (image-dired-previous-line)) > > > > looks like a kludge. Can't we have a cleaner code for updating the > > header data? If image-dired-previous/next-line can update the data, > > why cannot the scroll commands do the same without calling the > > line-movement commands? > > You're right. Here is a cleaner version inspired by > `image-dired--movement-command-line'. Hmm... okay, but I wonder why not call image-dired-track-original-file and image-dired--update-header-line directly from each of these new commands, after scroll-up/down, instead of implementing this as a macro (which calls another macro). That would have been much simpler and easier to follow. Or is there something I'm missing here? Thanks.