From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 65052@debbugs.gnu.org
Subject: bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired
Date: Sat, 05 Aug 2023 13:02:53 +0300 [thread overview]
Message-ID: <83y1ipst6a.fsf@gnu.org> (raw)
In-Reply-To: <87zg35c00j.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 05 Aug 2023 11:27:08 +0200)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 65052@debbugs.gnu.org
> Date: Sat, 05 Aug 2023 11:27:08 +0200
>
> >> Hmm... okay, but I wonder why not call image-dired-track-original-file
> >> and image-dired--update-header-line directly from each of these new
> >> commands, after scroll-up/down, instead of implementing this as a
> >> macro (which calls another macro). That would have been much simpler
> >> and easier to follow. Or is there something I'm missing here?
> >
> > Yes it would be much simpler. I was trying to "stay in line" with the
> > current code. I could try to add the scroll-up/down feature and maybe,
> > in a later patch, try to remove thoses macros. WDYT?
>
> Here. The code is more obvious this way and I think we should do the
> same for other movements.
Yes, thanks.
next prev parent reply other threads:[~2023-08-05 10:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 14:55 bug#65052: 30.0.50; [PATCH] Scroll-{up, down} does not update tracking info in image-dired Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 15:24 ` Eli Zaretskii
2023-08-04 18:25 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-04 19:07 ` Eli Zaretskii
2023-08-04 20:58 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 5:43 ` Eli Zaretskii
2023-08-05 8:32 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 9:27 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 10:02 ` Eli Zaretskii [this message]
2023-08-05 12:58 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 13:12 ` Eli Zaretskii
2023-08-05 13:27 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-05 15:28 ` Eli Zaretskii
2023-08-05 17:39 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-10 9:11 ` Eli Zaretskii
2023-08-12 8:56 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-12 8:59 ` Eli Zaretskii
2023-08-05 9:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1ipst6a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65052@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.