From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Android port
Date: Mon, 07 Aug 2023 14:19:57 +0300
Message-ID: <83y1innlpe.fsf@gnu.org>
References: <1428589171.162865.1691134964773@mail1.libero.it>
 <83h6pcrbe9.fsf@gnu.org>
 <d791cad9-e66b-e176-07d6-1c85d4c29f36@cs.ucla.edu>
 <11660747.27k8W16iEi@nimes> <87a5v45pmj.fsf@yahoo.com>
 <15527b3e-9334-c03d-e0a5-0828381a0071@cs.ucla.edu>
 <838raooy85.fsf@gnu.org> <875y5r4tfa.fsf@yahoo.com>
 <871qgf4qxs.fsf@yahoo.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="18131"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: eggert@cs.ucla.edu, angelo.g0@libero.it, emacs-devel@gnu.org,
 bruno@clisp.org
To: Po Lu <luangruo@yahoo.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 07 13:30:51 2023
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1qSyRm-0003tj-8j
	for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Aug 2023 13:30:51 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1qSyH1-0008HJ-MR; Mon, 07 Aug 2023 07:19:43 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1qSyGz-0008H4-Pn
 for emacs-devel@gnu.org; Mon, 07 Aug 2023 07:19:41 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1qSyGx-0007kP-G9; Mon, 07 Aug 2023 07:19:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=1sMRKV8g6orcaaSV5Z4MvxbQs5c1MKqyGcaDBPKLCgM=; b=ELbd7gznRAE3
 NkT/2GmyXjNqd1oJdKvxzmLQKtef1h8rG47sc2QgguM62Ql+MlGLtfkXRJrTjKy1CM6+NA/nyzwo1
 ELCU97bbVOP3KIfE+ZQFpIPScu4A4sLcOvsGjhw+AI5GayU1HVDDAuDAPDlYQxMolQVslNUa6PQpu
 VGRhtjTdSlZTx/qP8m0VFuhaHFDQEeE6CG1jNxcjo1/yjpwp9pLKJ/4v8M7m1dRRtTXcmfH3x+vzn
 1zxDgcsVQTAfh9rVII+sGXuyxtUaDjdNrFPkYZsBJ2oHVK7D7T2SYdvyoM5rD/O2dYuBPNYa/tksW
 flM266C1eRMSfp285acAhA==;
In-Reply-To: <871qgf4qxs.fsf@yahoo.com> (message from Po Lu on Mon, 07 Aug
 2023 08:49:35 +0800)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:308409
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/308409>

> From: Po Lu <luangruo@yahoo.com>
> Cc: Paul Eggert <eggert@cs.ucla.edu>,  angelo.g0@libero.it,
>   emacs-devel@gnu.org,  bruno@clisp.org
> Date: Mon, 07 Aug 2023 08:49:35 +0800
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >>> Date: Sun, 6 Aug 2023 10:44:09 -0700
> >>> Cc: Eli Zaretskii <eliz@gnu.org>, angelo.g0@libero.it, emacs-devel@gnu.org,
> >>>  Bruno Haible <bruno@clisp.org>
> >>> From: Paul Eggert <eggert@cs.ucla.edu>
> >>> 
> >>> I understand the reluctance from the Android point of view. However, 
> >>> printf-posix imports 69 new source files to Emacs, and these files have 
> >>> not been tested extensively with Emacs on non-Android platforms. From 
> >>> the viewpoint of non-Android Emacs platforms, it's significantly less 
> >>> disruptive if merging the Android branch does not add 69 new source 
> >>> files that will require testing on these platforms.
> >>> 
> >>> And even from the Android viewpoint, no matter what we do to fix the 
> >>> problem some testing needs to be done anyway, as the fix is likely to 
> >>> affect Emacs in test-relevant ways.
> >>
> >> I think Paul makes a good point here about those modules not being
> >> tested in Emacs on other platforms.  Avoiding addition of 69 files to
> >> Emacs is also a non-trivial gain.
> >>
> >> Since Emacs 30.1 will not be released any time soon, I think we will
> >> have ample time to test it without the *printf modules, and find out
> >> and fix any issues this could create.
> >>
> >> So I suggest to give this solution a chance.
> >>
> >>> The idea is to get feature/android merged quickly. We can revisit the 
> >>> use of Gnulib's printf-posix module later, as needed. With luck 
> >>> printf-posix won't be needed, as Emacs historically has avoided use of 
> >>> unusual printf features (for obvious portability reasons).
> >>
> >> Right.
> >
> > I plan to quickly test this on some old versions of Android and ack.
> 
> Cursory inspection indicates that Emacs functions correctly without the
> *printf modules on Android 2.3, 4.0.1 and 4.4, so I've ommitted the
> modules and merged the branch to master, after removing the w32-specific
> code that disables them.

Thanks.  It looks like nt/gnulib-cfg.mk still names modules that were
eventually removed?  Could you please audit the modules added to
gnulib-cfg.mk and remove the lines that are no longer needed on
master?