From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 32fe187bdf1: Install rcs2log within Emacs packages for Android Date: Thu, 24 Aug 2023 11:53:57 +0300 Message-ID: <83y1i0q0re.fsf@gnu.org> References: <833508rj7j.fsf@gnu.org> <871qfs7rwb.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35677"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 24 10:54:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZ67D-0008tg-ML for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Aug 2023 10:54:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ65v-0004YC-Hp; Thu, 24 Aug 2023 04:53:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ65u-0004WQ-4m for emacs-devel@gnu.org; Thu, 24 Aug 2023 04:53:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ65t-0002Mj-Sq; Thu, 24 Aug 2023 04:53:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jJFSzK3rojl/n0oz4mIbPgRvp9zcOYRTdw7Hyo4oasg=; b=MjhlXq7KaaPK j7nQqcC6pdvGvl83Ah6v3xmL8uz8CMmeqke6Ukn0uGvGBeMaeSZwiT+eMLMJnnT9LqXU9LkBgafsY XoIF2HlW0X549uzMVvGSRXtPkiLGVmTdKnFBx1YhiajeKtT2IJdBM/ctTTcM4fcKVHui4KjJKnZ4Y /a6BKyxHAh4K5ReDqRIx5wplaqB/9Jz1q9CUZ6VaaF6FulGbC9VdLmWwoOAF5/GyPSwlF4efQdKq5 o2JRC0tf8W6SvK3GlJCQeE9ZBxHevqQm1h9IMlmKj9scnwZCK02aDf2kDGOokQwv9LLq3GfAnFxj/ iJZkT/kJ6kI+B1DzxlMa8g==; In-Reply-To: <871qfs7rwb.fsf@yahoo.com> (message from Po Lu on Thu, 24 Aug 2023 16:42:44 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309152 Archived-At: > From: Po Lu > Cc: emacs-devel@gnu.org > Date: Thu, 24 Aug 2023 16:42:44 +0800 > > Eli Zaretskii writes: > > >> * src/callproc.c (syms_of_callproc) : New > >> defvar. Define to `librcs2log.so' under Android, `rcs2log' > > > > Why do we need this variable defined and initialized in C? Can't we > > do that in Lisp instead? Since vc-rcs.el needs it, can't the variable > > be defined there, for example? > > We do this for consistency with the other -program-name variables for > programs within exec-directory. Those other variables should be moved out of there as well, IMO. They are recent additions, AFAIU as part of the Android merge. I see no reason to have them defined in C, as they are not invoked from any C code, are they? > Moreover, Lisp other than vc-rcs.el may want to use rcs2log: it > helps to have its name defined in a central location, instead of > forcing everyone to either require vc or duplicate the definition > within syms_of_callproc. OK, then let's have them in simple.el or in files.el. Or any other preloaded Lisp, if those two don't sound appropriate.