From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 32fe187bdf1: Install rcs2log within Emacs packages for Android
Date: Thu, 24 Aug 2023 11:53:57 +0300 [thread overview]
Message-ID: <83y1i0q0re.fsf@gnu.org> (raw)
In-Reply-To: <871qfs7rwb.fsf@yahoo.com> (message from Po Lu on Thu, 24 Aug 2023 16:42:44 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 24 Aug 2023 16:42:44 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> * src/callproc.c (syms_of_callproc) <Vrcs2log_program_name>: New
> >> defvar. Define to `librcs2log.so' under Android, `rcs2log'
> >
> > Why do we need this variable defined and initialized in C? Can't we
> > do that in Lisp instead? Since vc-rcs.el needs it, can't the variable
> > be defined there, for example?
>
> We do this for consistency with the other -program-name variables for
> programs within exec-directory.
Those other variables should be moved out of there as well, IMO. They
are recent additions, AFAIU as part of the Android merge. I see no
reason to have them defined in C, as they are not invoked from any C
code, are they?
> Moreover, Lisp other than vc-rcs.el may want to use rcs2log: it
> helps to have its name defined in a central location, instead of
> forcing everyone to either require vc or duplicate the definition
> within syms_of_callproc.
OK, then let's have them in simple.el or in files.el. Or any other
preloaded Lisp, if those two don't sound appropriate.
next prev parent reply other threads:[~2023-08-24 8:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 7:30 master 32fe187bdf1: Install rcs2log within Emacs packages for Android Eli Zaretskii
2023-08-24 8:42 ` Po Lu
2023-08-24 8:53 ` Eli Zaretskii [this message]
2023-08-24 9:30 ` Po Lu
2023-08-24 10:01 ` Eli Zaretskii
2023-08-24 10:11 ` Po Lu
2023-08-24 10:37 ` Eli Zaretskii
2023-08-24 10:51 ` Andreas Schwab
2023-08-24 11:08 ` Eli Zaretskii
2023-08-24 12:24 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1i0q0re.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.