bug#65994: 29.1; emoji-zoom-* functions does not work with list of face symbols

bug#65994: 29.1; emoji-zoom-* functions does not work with list of face symbols

[awrhygty]

Evaluate the form below and type 'C-x 8 e +', an error occurs:
  Wrong type argument: plistp, highlight

(let ((buf (generate-new-buffer "temp")))
  (switch-to-buffer buf)
  (insert (propertize "x" 'face '(highlight)))
  (forward-char -1))


In GNU Emacs 29.1 (build 2, x86_64-w64-mingw32) of 2023-08-02 built on
 AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.3448)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation=aot
 --without-compress-install --with-tree-sitter CFLAGS=-O2'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

(NATIVE_COMP present but libgccjit not available)

Important settings:
  value of $LANG: JPN
  locale-coding-system: cp932

Major mode: Lisp Interaction

Minor modes in effect:
  highlight-changes-visible-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(misearch multi-isearch comp comp-cstr warnings icons rx emoji-labels
emoji multisession sqlite transient format-spec edmacro kmacro cl-extra
gnutls network-stream nsm mailalias smtpmail textsec uni-scripts url
url-proxy url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util url-parse auth-source cl-seq
eieio eieio-core cl-macs json map url-vars idna-mapping ucs-normalize
uni-confusable textsec-check cl-print byte-opt gv bytecomp byte-compile
debug backtrace find-func hilit-chg wid-edit thingatpt help-fns
radix-tree help-mode pp shadow sort mail-extr emacsbug message mailcap
yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache
epa derived epg rfc6068 epg-config gnus-util text-property-search
time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils term/bobcat japan-util
rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table
term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 280036 41310)
 (symbols 48 11821 5)
 (strings 32 63568 3485)
 (string-bytes 1 1289281)
 (vectors 16 52938)
 (vector-slots 8 1587390 174382)
 (floats 8 69 384)
 (intervals 56 3272 646)
 (buffers 984 16))

bug#65994: 29.1; emoji-zoom-* functions does not work with list of face symbols

[Eli Zaretskii]

> From: awrhygty@outlook.com
> Date: Fri, 15 Sep 2023 21:14:08 +0900
> 
> 
> Evaluate the form below and type 'C-x 8 e +', an error occurs:
>   Wrong type argument: plistp, highlight
> 
> (let ((buf (generate-new-buffer "temp")))
>   (switch-to-buffer buf)
>   (insert (propertize "x" 'face '(highlight)))
>   (forward-char -1))

Thanks, should be fixed now on the emacs-29 branch.

Please in the future try to make the bug reports less terse and thus
more helpful by telling which parts of the recipe are crucial for the
issue, and/or what is the deficiency in the code that the recipe
uncovers.  In this case, the crucial part is this:

   (insert (propertize "x" 'face '(highlight)))
                                 ^^^^^^^^^^^^
i.e., the fact that the value of 'face' is a list of face symbols,
something that the code was not prepared for.  Stating this explicitly
in the bug report would have saved me some minutes of figuring out
what was going on here and why.  Please don't assume that people who
investigate the bug report are necessarily experts in the relevant
code, let alone wrote that code themselves.  TIA for considering these
aspects in your future bug reports.

bug#65994: 29.1; emoji-zoom-* functions does not work with list of face symbols

[Eli Zaretskii]

> Cc: 65994@debbugs.gnu.org
> Date: Sat, 16 Sep 2023 10:38:56 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: awrhygty@outlook.com
> > Date: Fri, 15 Sep 2023 21:14:08 +0900
> > 
> > 
> > Evaluate the form below and type 'C-x 8 e +', an error occurs:
> >   Wrong type argument: plistp, highlight
> > 
> > (let ((buf (generate-new-buffer "temp")))
> >   (switch-to-buffer buf)
> >   (insert (propertize "x" 'face '(highlight)))
> >   (forward-char -1))
> 
> Thanks, should be fixed now on the emacs-29 branch.

Closing.