From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66149: Mistyping a search breaks keyboard macro Date: Sat, 23 Sep 2023 11:58:49 +0300 Message-ID: <83y1gx465y.fsf@gnu.org> References: <2bba5a744feb000a4ffc1fef79d223fcf24953e7.camel@yandex.ru> <83sf7678fv.fsf@gnu.org> <86fs36ql6i.fsf@mail.linkov.net> <61c24e6086f4ce5125d78490a587c1d1193f65dc.camel@yandex.ru> <834jjl5nfr.fsf@gnu.org> <4fccb4b82092c7fa085527597561d0f66e12eb9b.camel@yandex.ru> <8334z55ls0.fsf@gnu.org> <1fefaf0472e92c20b0170b02c0ad3820b10e8978.camel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12613"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66149@debbugs.gnu.org, stefankangas@gmail.com, juri@linkov.net To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 23 10:59:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjyTe-00032B-Di for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Sep 2023 10:59:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjyTV-0002nc-VY; Sat, 23 Sep 2023 04:58:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjyTU-0002mf-FD for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 04:58:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjyTT-0001HF-7X for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 04:58:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjyTe-0001KC-9i for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2023 04:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2023 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66149 X-GNU-PR-Package: emacs Original-Received: via spool by 66149-submit@debbugs.gnu.org id=B66149.16954595365081 (code B ref 66149); Sat, 23 Sep 2023 08:59:02 +0000 Original-Received: (at 66149) by debbugs.gnu.org; 23 Sep 2023 08:58:56 +0000 Original-Received: from localhost ([127.0.0.1]:37765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjyTY-0001Js-9M for submit@debbugs.gnu.org; Sat, 23 Sep 2023 04:58:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjyTW-0001Jc-DT for 66149@debbugs.gnu.org; Sat, 23 Sep 2023 04:58:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjyTF-0001Fm-2w; Sat, 23 Sep 2023 04:58:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hwEV+ebeadgq/HL2/MQRS2U2AoW/cikQpvN9Z1wrsU0=; b=AZ7vnJ6eRSI3iBx+QOYz eFstWngKWh1igmZ0QUqvABQUO52wlNoOEdmPJ+4brc6ABXZ6fEreSUTw5WxwIxT8BtS38MhCcTRlT rSFHVFm1haw4YX4/BkquKFevfsh/HmMFyb49LukXo6rOL1rtulZZ1UMuYXyTNRKP0XSQaEA7HcA62 CH9Q7ah4M44Vo1N1n+qXjpt5iyw9Y+Qzv7xWRnv1cR9THzyYDEBrSdNvbSVT/eniw2GLjCMjUIasi jCVLoeeUqKFgooGImEC3flQXn26A/vuWU5s/2EI6aAegHRAbGiavchC4oF86KyJe6E690XUPrR/6P K/GlYFR/+6WItw==; In-Reply-To: <1fefaf0472e92c20b0170b02c0ad3820b10e8978.camel@yandex.ru> (message from Konstantin Kharlamov on Sat, 23 Sep 2023 11:43:56 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271148 Archived-At: > From: Konstantin Kharlamov > Cc: juri@linkov.net, 66149@debbugs.gnu.org > Date: Sat, 23 Sep 2023 11:43:56 +0300 > > On Sat, 2023-09-23 at 11:36 +0300, Eli Zaretskii wrote: > > > From: Konstantin Kharlamov > > > Cc: juri@linkov.net, 66149-done@debbugs.gnu.org > > > Date: Sat, 23 Sep 2023 11:01:32 +0300 > > > > > > On Sat, 2023-09-23 at 11:00 +0300, Eli Zaretskii wrote: > > > > > From: Konstantin Kharlamov > > > > > Cc: 66149@debbugs.gnu.org > > > > > Date: Sat, 23 Sep 2023 10:14:59 +0300 > > > > > > > > > > On Fri, 2023-09-22 at 18:41 +0300, Juri Linkov wrote: > > > > > > > > > > > > > I have no opinion whether 'ding' should terminate kbd macro > > > > > > or > > > > > > not. > > > > > > But it's possible to customize 'isearch-wrap-pause' to 'no- > > > > > > ding' > > > > > > to not ding on isearch failure, then kbd macro is not > > > > > > terminated. > > > > > > > > > > Oh, thank you! So for example, having the following code in the > > > > > init > > > > > file works around the problem: > > > > > > > > > >     (defadvice kmacro-call-macro (around align-regexp-with- > > > > > spaces > > > > > activate) > > > > >       (let ((isearch-wrap-pause 'no-ding)) > > > > >         ad-do-it)) > > > > > > > > > > I'll post an answer about that on the emacs.stackexchange then. > > > > > > > > And I'm closing the bug. > > >   > > > Why? The problem is still relevant. A workaround is not a fix. > > > > because the motivation to make any such changes is now even lower > > than > > it was before, and I don't want to keep bugs open when nothing is > > being done for them, nor ever will be. > > Oh, okay, so, a fix for this closed bug will still be accepted? We accept worthy improvements even if there's no bug at all for them, so yes, of course. The important thing is that the change is clean and doesn't bring any problems with it.