From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67034: 30.0.50; Make `derived-mode-p` take a single arg Date: Fri, 17 Nov 2023 10:24:32 +0200 Message-ID: <83y1ewokhr.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15625"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67034@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 17 09:25:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3uAO-0003sr-3S for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Nov 2023 09:25:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3uA7-0001SD-P9; Fri, 17 Nov 2023 03:25:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3u9w-0001NO-G0 for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 03:25:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3u9v-0001B1-5B for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 03:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3u9t-0003k2-P6 for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 03:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Nov 2023 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67034 X-GNU-PR-Package: emacs Original-Received: via spool by 67034-submit@debbugs.gnu.org id=B67034.170020949114350 (code B ref 67034); Fri, 17 Nov 2023 08:25:01 +0000 Original-Received: (at 67034) by debbugs.gnu.org; 17 Nov 2023 08:24:51 +0000 Original-Received: from localhost ([127.0.0.1]:45075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3u9i-0003jO-Jh for submit@debbugs.gnu.org; Fri, 17 Nov 2023 03:24:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3u9c-0003j6-Vd for 67034@debbugs.gnu.org; Fri, 17 Nov 2023 03:24:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3u9V-00017H-SA; Fri, 17 Nov 2023 03:24:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TbWVwWPzeQV05osOvsuc5QjVriouPLKpbrYUXKVxsdA=; b=m+5+rHrTK+Dj N5tTzNVbq/P6YV16gVnrFE+S1Sn5achavFT8RZhmdt9kr2ukvFvGYNEBrmJyEi+Lj09saZrNTjgx7 +9zoj+Xy+VLZAS2Es+6fQ/WbSNqKtNmodJARvgRZofIH0KM9VoHz3431U2gO/ryeqKrGBHvamatsq yWFuRXXa4PY5O5N4x5621QJrRfOIR7SdTv9w2n/lPbooqh44jEUvrw4xDum5wf8afmzGyh6j77svm 6+zyquKOqMSWdDkRilct43rbsEwSWUWb2tVEtdWvcA9UG8zuSRizOW48V+8dXZ3y0Nlnp6LCeEFm3 1VpDtp1jXZ0QEWPIDwyAjw==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274492 Archived-At: > Date: Thu, 16 Nov 2023 17:28:24 -0500 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > -@defun derived-mode-p &rest modes > +@defun derived-mode-p modes > This function returns non-@code{nil} if the current major mode is > derived from any of the major modes given by the symbols @var{modes}. > +Instead of a list, @var{modes} can also be a single symbol. If MODES is supposed to be a list, then why does the first sentence say "given by the symbols MODES"? It should probably say "given by the list of symbols in MODES" instead, right? And the last sentence would be a tad less confusing if it said Instead of a list, @var{modes} can also be a single mode symbol. > -(defun provided-mode-derived-p (mode &rest modes) > +(defun provided-mode-derived-p (mode &optional modes &rest old-modes) > "Non-nil if MODE is derived from one of MODES. This should IMO say Non-nil if MODE is derived from a mode that is a member of the list MODES. > +(defun derived-mode-p (&optional modes &rest old-modes) > + "Non-nil if the current major mode is derived from one of MODES. Likewise here. Thanks.