all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 67034@debbugs.gnu.org
Subject: bug#67034: 30.0.50; Make `derived-mode-p` take a single arg
Date: Fri, 17 Nov 2023 10:24:32 +0200	[thread overview]
Message-ID: <83y1ewokhr.fsf@gnu.org> (raw)
In-Reply-To: <jwv34x5jpul.fsf-monnier+emacs@gnu.org> (bug-gnu-emacs@gnu.org)

> Date: Thu, 16 Nov 2023 17:28:24 -0500
> From:  Stefan Monnier via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> -@defun derived-mode-p &rest modes
> +@defun derived-mode-p modes
>  This function returns non-@code{nil} if the current major mode is
>  derived from any of the major modes given by the symbols @var{modes}.
> +Instead of a list, @var{modes} can also be a single symbol.

If MODES is supposed to be a list, then why does the first sentence
say "given by the symbols MODES"?  It should probably say "given by
the list of symbols in MODES" instead, right?

And the last sentence would be a tad less confusing if it said

  Instead of a list, @var{modes} can also be a single mode symbol.

> -(defun provided-mode-derived-p (mode &rest modes)
> +(defun provided-mode-derived-p (mode &optional modes &rest old-modes)
>    "Non-nil if MODE is derived from one of MODES.

This should IMO say

  Non-nil if MODE is derived from a mode that is a member of the list MODES.

> +(defun derived-mode-p (&optional modes &rest old-modes)
> + "Non-nil if the current major mode is derived from one of MODES.

Likewise here.

Thanks.





  reply	other threads:[~2023-11-17  8:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  3:58 bug#67034: 30.0.50; Make `derived-mode-p` take a single arg Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 12:18 ` Daniel Mendler
2023-11-11  0:04   ` Dmitry Gutov
2023-11-11  9:08     ` Daniel Mendler
2023-11-16 22:38   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 22:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-17  8:24   ` Eli Zaretskii [this message]
2023-11-17 21:18     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-23 17:00       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1ewokhr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=67034@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.