From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Date: Tue, 19 Dec 2023 18:52:47 +0200 Message-ID: <83y1dqgmn4.fsf@gnu.org> References: <87h6lruah2.fsf@yandex.ru> <83y1ezqhhk.fsf@gnu.org> <3B375BD3-CF92-4473-AC46-50D6052B79C2@gmail.com> <831qcmmh0e.fsf@gnu.org> <31EB2F37-286D-4910-958B-0152A85E970F@gmail.com> <838r6ukss1.fsf@gnu.org> <87051700392856@mail.yandex.ru> <83zfzaj7b4.fsf@gnu.org> <1302931702945138@mail.yandex.ru> <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23490"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 19 17:54:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFdMP-0005w3-K3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Dec 2023 17:54:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFdM1-0006Kl-BP; Tue, 19 Dec 2023 11:54:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFdLz-0006Kc-NY for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 11:53:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFdLz-0003ez-E8 for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 11:53:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFdM1-0004IJ-OK for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 11:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67117-submit@debbugs.gnu.org id=B67117.170300479716443 (code B ref 67117); Tue, 19 Dec 2023 16:54:01 +0000 Original-Received: (at 67117) by debbugs.gnu.org; 19 Dec 2023 16:53:17 +0000 Original-Received: from localhost ([127.0.0.1]:37198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFdLI-0004H9-VS for submit@debbugs.gnu.org; Tue, 19 Dec 2023 11:53:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFdLH-0004Gs-Ly for 67117@debbugs.gnu.org; Tue, 19 Dec 2023 11:53:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFdL9-0003Qm-6x; Tue, 19 Dec 2023 11:53:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XNQmT10jDEgocKtGCHIoWA9KnjLRh6cxjJ0UaH2SY54=; b=UD5vk+yfgHww RCmiTkVtChj7m3Ki/+b9afXRBDk7e/4b+S4Wf07RIPHwW1ZqvyUvv59Y0ftMgoTNQ5d3fb7hvHm7b zXuzxzcvMnouHDg9TGfPWkxpECcgvhKTsoLsQsFxeDVH22Wt8gJVro3w/o5CnNSh2Gix9MYO5pqVn RS1xUHpjnu5RJ2kQ3JaDYCmb7v4b9LZVVVN2XXw9NtDWZSP9pJkgXcMhc0LGmnId6/IwV6m52QTQX vtsW+jEwvlUzEB8qK6hrO1cvevNTQlEEji4F7IZl3pvwVIOUH2qKHAVsyaiiJapX8tFUW5XqBtkH4 p6V2JTI+02BBmyo6bEThrA==; In-Reply-To: <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> (message from Yuan Fu on Mon, 18 Dec 2023 18:26:30 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276527 Archived-At: > From: Yuan Fu > Date: Mon, 18 Dec 2023 18:26:30 -0800 > Cc: Eli Zaretskii , > 67117-done@debbugs.gnu.org > > > On Dec 18, 2023, at 4:24 PM, Denis Zubarev wrote: > > > > Just FYI, my paperwork is done. > > > > Great, applied! Closing this bug. The new tests fail here: ELC src/treesit-tests.elc In end of data: src/treesit-tests.el:1094:17: Warning: the function `treesit--thing-at' is not known to be defined. [...] Test treesit-search-subtree-backward-1 backtrace: (treesit--thing-at (point) "call") (treesit-search-subtree (treesit--thing-at (point) "call") #'(lambda (let ((node (treesit-search-subtree (treesit--thing-at (point) "call (closure (t) nil (let* ((fn-621 #'treesit-language-available-p) (arg ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name treesit-search-subtree-backward-1 :do ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" "-- command-line() normal-top-level() Test treesit-search-subtree-backward-1 condition: (void-function treesit--thing-at) FAILED 24/25 treesit-search-subtree-backward-1 (0.000000 sec) at src/treesit-tests.el:1100 Can't guess python-indent-offset, using defaults: 4 Test treesit-search-subtree-forward-1 backtrace: (treesit--thing-at (point) "call") (treesit-search-subtree (treesit--thing-at (point) "call") #'(lambda (let ((node (treesit-search-subtree (treesit--thing-at (point) "call (closure (t) nil (let* ((fn-609 #'treesit-language-available-p) (arg ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name treesit-search-subtree-forward-1 :doc ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" "-- command-line() normal-top-level() Test treesit-search-subtree-forward-1 condition: (void-function treesit--thing-at) FAILED 25/25 treesit-search-subtree-forward-1 (0.015625 sec) at src/treesit-tests.el:1086 The function treesit--thing-at is only available on master.