all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 67117@debbugs.gnu.org, dvzubarev@yandex.ru
Subject: bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward
Date: Tue, 19 Dec 2023 18:52:47 +0200	[thread overview]
Message-ID: <83y1dqgmn4.fsf@gnu.org> (raw)
In-Reply-To: <6D360CF2-666F-4BFE-AF6E-98F47829B338@gmail.com> (message from Yuan Fu on Mon, 18 Dec 2023 18:26:30 -0800)

> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 18 Dec 2023 18:26:30 -0800
> Cc: Eli Zaretskii <eliz@gnu.org>,
>  67117-done@debbugs.gnu.org
> 
> > On Dec 18, 2023, at 4:24 PM, Denis Zubarev <dvzubarev@yandex.ru> wrote:
> > 
> > Just FYI, my paperwork is done.
> > 
> 
> Great, applied! Closing this bug.

The new tests fail here:

    ELC      src/treesit-tests.elc

  In end of data:
  src/treesit-tests.el:1094:17: Warning: the function `treesit--thing-at' is not known to be defined.
  [...]
  Test treesit-search-subtree-backward-1 backtrace:
    (treesit--thing-at (point) "call")
    (treesit-search-subtree (treesit--thing-at (point) "call") #'(lambda
    (let ((node (treesit-search-subtree (treesit--thing-at (point) "call
    (closure (t) nil (let* ((fn-621 #'treesit-language-available-p) (arg
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name treesit-search-subtree-backward-1 :do
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
    ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
    ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
    eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
    command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" "--
    command-line()
    normal-top-level()
  Test treesit-search-subtree-backward-1 condition:
      (void-function treesit--thing-at)
     FAILED  24/25  treesit-search-subtree-backward-1 (0.000000 sec) at src/treesit-tests.el:1100
  Can't guess python-indent-offset, using defaults: 4
  Test treesit-search-subtree-forward-1 backtrace:
    (treesit--thing-at (point) "call")
    (treesit-search-subtree (treesit--thing-at (point) "call") #'(lambda
    (let ((node (treesit-search-subtree (treesit--thing-at (point) "call
    (closure (t) nil (let* ((fn-609 #'treesit-language-available-p) (arg
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name treesit-search-subtree-forward-1 :doc
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
    ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
    ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
    eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
    command-line-1(("-L" ";." "-l" "ert" "-l" "src/treesit-tests.el" "--
    command-line()
    normal-top-level()
  Test treesit-search-subtree-forward-1 condition:
      (void-function treesit--thing-at)
     FAILED  25/25  treesit-search-subtree-forward-1 (0.015625 sec) at src/treesit-tests.el:1086

The function treesit--thing-at is only available on master.





  reply	other threads:[~2023-12-19 16:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 23:38 bug#67117: [PATCH] Tree-sitter: fix an issue when searching subtree backward Denis Zubarev
2023-11-15 13:21 ` Eli Zaretskii
2023-11-15 17:01   ` Eli Zaretskii
2023-11-18 18:47   ` Yuan Fu
2023-11-19  5:47     ` Eli Zaretskii
2023-11-19  6:13       ` Yuan Fu
2023-11-19  6:40         ` Eli Zaretskii
2023-11-21  4:23           ` Yuan Fu
2023-11-21 11:43             ` Eli Zaretskii
2023-11-25  3:44               ` Yuan Fu
2023-11-19  9:15         ` Eli Zaretskii
2023-11-19 11:25           ` Denis Zubarev
2023-11-19 11:45             ` Eli Zaretskii
2023-12-19  0:24               ` Denis Zubarev
2023-12-19  2:26                 ` Yuan Fu
2023-12-19 16:52                   ` Eli Zaretskii [this message]
2023-12-19 17:08                     ` Denis Zubarev
2023-12-23  7:09                       ` Yuan Fu
2023-12-26  0:39                         ` Yuan Fu
2023-12-19  3:24                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1dqgmn4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=67117@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dvzubarev@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.