From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68185: [PATCH] Ensure indent-region argument order is correct Date: Thu, 04 Jan 2024 13:22:56 +0200 Message-ID: <83y1d5wdf3.fsf@gnu.org> References: <87zfxq574q.fsf@ice9.digital> <87wmstnfxd.fsf@ice9.digital> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68185@debbugs.gnu.org To: Morgan Willcock Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 04 12:24:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rLLpc-000AB4-Qa for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jan 2024 12:24:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLLpQ-0003s3-Jc; Thu, 04 Jan 2024 06:24:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLLpO-0003rg-Hd for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 06:23:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLLpO-000367-9l for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 06:23:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rLLpR-0006Wt-LA for bug-gnu-emacs@gnu.org; Thu, 04 Jan 2024 06:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jan 2024 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68185 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68185-submit@debbugs.gnu.org id=B68185.170436740725044 (code B ref 68185); Thu, 04 Jan 2024 11:24:01 +0000 Original-Received: (at 68185) by debbugs.gnu.org; 4 Jan 2024 11:23:27 +0000 Original-Received: from localhost ([127.0.0.1]:53721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLLos-0006Vr-H7 for submit@debbugs.gnu.org; Thu, 04 Jan 2024 06:23:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rLLop-0006VY-S5 for 68185@debbugs.gnu.org; Thu, 04 Jan 2024 06:23:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLLog-000147-I3; Thu, 04 Jan 2024 06:23:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZfTXDK8G50JjA/RQobXPZSj/47zQ6UzCf+rHn9i7ons=; b=CEN76iGuZpNL kEhZ4C3Qm7gfpnutnr1jHOn5BiVsi+tRO+FYk5fJhciwX00pUEgJRgR048on4bDXVV+ScfjuyI2oc S5V+lw6uEZ0GvmwWLHE21CkTa/xgCUUJZBu0A4TnwRzhuI05bzRJt+hT+nD7d7bljcayTxKTsicc4 gzJ75q8D+oleO6fjrX5rR9qW5f+qGC0U+Z2ME6xtMgAc559T785l+7/wsNFLMfRTOilZBBBXJjf2E R2jcjeogCDwS2seJ68TsiTdxCnAv1tKOUN+f5HCY3p5FYXVUBKXF+T+rL7mkNTvJs5r8lbt6Hg+HN IGhivvXycG0489dZZZXorw==; In-Reply-To: <87wmstnfxd.fsf@ice9.digital> (message from Morgan Willcock on Mon, 01 Jan 2024 17:04:30 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277310 Archived-At: > From: Morgan Willcock > Date: Mon, 01 Jan 2024 17:04:30 +0000 > > Attached is a replacement patch which I believe fixes the issue with the > region selection direction and with indentation potentially being > incorrectly applied to text that is inserted by the template. > > Previously when text was being inserted at the region start it was > actually going into region, which means that it will have been possible > for template contents to have accidentally been indented along with the > region that the user selected. I've changed the marker insertion type > for the start boundary, which should preserve the original indentation > of text which was inserted by the template, i.e. if text inserted by the > template should be indented this is now back under control of the > template rather than applied by accident. > > The changes do mean that the indentation of existing templates may > change, but I think this will only be for templates which accidentally > omitted the indentation directives because indentation was mistakenly > applied as part of the region. Thanks, installed (the additional part which wasn't in the previous patch).