Filtering loaddefs files in lisp/Makefile

Filtering loaddefs files in lisp/Makefile

[Eli Zaretskii]

What do people think about replacing this ugliness:

	    els=`echo $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lisptagsfiles4) | sed -e "s,$(lisp)/[^ ]*loaddefs[^ ]*,," -e "s,$(lisp)/ldefs-boot[^ ]*,,"`; \
	    ${ETAGS} -o $@ $$els

with a command that uses `find', e.g.:

	find . -name "*.el" -a -\! -( -name "*loaddefs.el" -o -name "ldefs-boot.el" -) | ${ETAGS} -o $@ -

The combined length of all the Lisp files expanded from
$(lisptagsfilesN) is 32K, so I guess a few shells will choke on what
we currently have, while doing it with `find' will avoid that problem.
As a bonus, we won't need to track the depth of the `lisp' tree
hierarchy by adding more of the $(lisptagsfilesN) variables.

Re: Filtering loaddefs files in lisp/Makefile

[Chong Yidong]

Eli Zaretskii <eliz@gnu.org> writes:

> What do people think about replacing this ugliness:
>
> 	    els=`echo $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lisptagsfiles4) | sed -e "s,$(lisp)/[^ ]*loaddefs[^ ]*,," -e "s,$(lisp)/ldefs-boot[^ ]*,,"`; \
> 	    ${ETAGS} -o $@ $$els
>
> with a command that uses `find', e.g.:
>
> 	find . -name "*.el" -a -\! -( -name "*loaddefs.el" -o -name "ldefs-boot.el" -) | ${ETAGS} -o $@ -
>
> The combined length of all the Lisp files expanded from
> $(lisptagsfilesN) is 32K, so I guess a few shells will choke on what
> we currently have, while doing it with `find' will avoid that problem.
> As a bonus, we won't need to track the depth of the `lisp' tree
> hierarchy by adding more of the $(lisptagsfilesN) variables.

Seems fine.

Re: Filtering loaddefs files in lisp/Makefile

[Francesco Potortì]

>Eli Zaretskii <eliz@gnu.org> writes:
>
>> What do people think about replacing this ugliness:
>>
>> 	    els=`echo $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lisptagsfiles4) | sed -e "s,$(lisp)/[^ ]*loaddefs[^ ]*,," -e "s,$(lisp)/ldefs-boot[^ ]*,,"`; \
>> 	    ${ETAGS} -o $@ $$els
>>
>> with a command that uses `find', e.g.:
>>
>> 	find . -name "*.el" -a -\! -( -name "*loaddefs.el" -o -name "ldefs-boot.el" -) | ${ETAGS} -o $@ -

The find manual says it is "\!", not "-!".  The following corrects the
above and is slightly simpler:

find . -name "*.el" -a \! -name "*loaddefs.el" -a \! -name "ldefs-boot.el" | ${ETAGS} -o $@ -

I think that inside a script quoting the ! is useless, as shell history
expansion is not enabled.  This would bring to this:

find . -name "*.el" -a ! -name "*loaddefs.el" -a ! -name "ldefs-boot.el" | ${ETAGS} -o $@ -