From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: oops? read/write vs type of length parameter Date: Fri, 15 Apr 2011 12:41:02 +0300 Message-ID: <83wrivq2c1.fsf@gnu.org> References: <87wrj1jhfc.fsf@rho.meyering.net> <87hba5yq0p.fsf@uwakimon.sk.tsukuba.ac.jp> <834o64sxd7.fsf@gnu.org> <4DA3A7F8.1020503@cs.ucla.edu> <83k4f0qijz.fsf@gnu.org> <4DA3DDCD.10700@cs.ucla.edu> <4DA40AFE.8050406@cs.ucla.edu> <4DA47581.9010509@cs.ucla.edu> <4DA80818.7040507@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1302860526 11874 80.91.229.12 (15 Apr 2011 09:42:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 15 Apr 2011 09:42:06 +0000 (UTC) Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, jim@meyering.net To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 15 11:42:01 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QAfXM-0003OG-V3 for ged-emacs-devel@m.gmane.org; Fri, 15 Apr 2011 11:42:01 +0200 Original-Received: from localhost ([::1]:33009 helo=lists2.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAfXM-0005f4-Hw for ged-emacs-devel@m.gmane.org; Fri, 15 Apr 2011 05:42:00 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:60173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAfXJ-0005ej-CT for emacs-devel@gnu.org; Fri, 15 Apr 2011 05:41:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QAfXI-0004br-EH for emacs-devel@gnu.org; Fri, 15 Apr 2011 05:41:57 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:58742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QAfXI-0004bb-4U for emacs-devel@gnu.org; Fri, 15 Apr 2011 05:41:56 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LJO00800TFMH000@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Fri, 15 Apr 2011 12:41:06 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.191.204]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LJO007B6TKG8MF0@a-mtaout20.012.net.il>; Fri, 15 Apr 2011 12:41:06 +0300 (IDT) In-reply-to: <4DA80818.7040507@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138497 Archived-At: > Date: Fri, 15 Apr 2011 01:55:52 -0700 > From: Paul Eggert > Cc: Eli Zaretskii , jim@meyering.net, emacs-devel@gnu.org > > Anyway, I changed all the size_ts to EMACS_INTs and committed the patch > (which fixed other bugs as already mentioned) as bzr 103919. The change you made in emacs_read makes it possible for it to read less than it was requested to: - while ((rtnval = read (fildes, buf, nbyte)) == -1 + while ((rtnval = read (fildes, buf, min (nbyte, MAX_RW_COUNT))) == -1 && (errno == EINTR)) QUIT; return (rtnval); } I don't think it's a good idea to silently truncate the request and rely on the callers to loop (although I think they all do for now). So I think we need a loop in emacs_read like what we do in emacs_write.