From: Eli Zaretskii <eliz@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 9943@debbugs.gnu.org
Subject: bug#9943: 24.0.91; Abort in check_glyph_memory
Date: Sat, 05 Nov 2011 15:18:11 +0200 [thread overview]
Message-ID: <83wrbek8rw.fsf@gnu.org> (raw)
In-Reply-To: <0A21B7C4-DE31-4F1F-BE3A-9C12A0B206C5@swipnet.se>
> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Sat, 5 Nov 2011 13:26:08 +0100
> Cc: Ken Brown <kbrown@cornell.edu>,
> 9943@debbugs.gnu.org
>
> >> #0 abort () at emacs.c:386
> >> No locals.
> >> #1 0x00404781 in check_glyph_memory () at dispnew.c:2370
> >> tail = 8775706
> >> frame = -2147299323
> >> #2 0x005149e8 in shut_down_emacs (sig=0, no_x=0, stuff=8775706)
> >> at emacs.c:2102
> >
> > Thanks, I installed a fix.
>
> I don't think it was quite correct.
Thanks for double-checking it.
> In x-create-frame terminal->reference_count gets incremented before record_unwind_protect, but it is not decremented in case the unwind protect function is called.
Isn't it safer (from the POV of potentially destabilizing Emacs during
a pretest) to leave the increment where it was, and decrement it in the
unwind protect function?
> Also, in w32term.c, image_cache_refcount is assigned before init_frame_faces is called, but in xterm.c, this is reversed. Indeed, turning on GLYPH_DEBUG and recreating this bug causes an assert violation in unwind_create_frame.
An old bug, now fixed. Thanks. (Looks like not many people have
GLYPH_DEBUG turned on these days.)
> I don't know about w32, but on ns and X, accessing FRAME_IMAGE_CACHE (f)->refcount before calling init_frame_faces causes a segmentation violation, as FRAME_IMAGE_CACHE (f) is NULL.
Even if it doesn't, it doesn't hurt to add the test in w32fns.c as
well.
> Also, there is a typo in the comment to unwind_create_frame, x_create_top_frame should be ..._tip_frame. This may have been an old thing.
>
> I fixed these issues on X and ns (I hope :-).
Thanks.
> > nsfns.m has a similar problem, but x-create-frame there doesn't have
> > an unwind-protect function to add a similar change. Can someone test
> > this recipe on a Mac?
>
> The same bug was present there, but is fixed now.
Thanks.
next prev parent reply other threads:[~2011-11-05 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 9:17 bug#9943: 24.0.91; Abort in check_glyph_memory martin rudalics
2011-11-03 19:08 ` Eli Zaretskii
2011-11-03 19:58 ` Glenn Morris
2011-11-03 21:05 ` Ken Brown
2011-11-03 21:59 ` Eli Zaretskii
2011-11-05 12:26 ` Jan Djärv
2011-11-05 13:18 ` Eli Zaretskii [this message]
2011-11-05 15:50 ` Jan Djärv
2011-11-05 16:27 ` Eli Zaretskii
2011-11-07 21:05 ` Glenn Morris
2011-11-03 21:57 ` Eli Zaretskii
2011-11-04 0:35 ` Stefan Monnier
2011-11-04 9:12 ` Eli Zaretskii
2011-11-04 16:53 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wrbek8rw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=9943@debbugs.gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.