From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11068: 24.0.94; Face-remapped background does not extend to end of window Date: Sat, 24 Mar 2012 22:47:13 +0200 Message-ID: <83wr69sp4e.fsf@gnu.org> References: <1BE52A40-0403-433F-8164-DFDBD6771F80@gmail.com> <83ty1fvc28.fsf@gnu.org> <83obrmtbsy.fsf@gnu.org> <4F6DCF31.3060609@gmx.at> <83fwcyt7f0.fsf@gnu.org> <4F6E24FD.2070907@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1332622090 5195 80.91.229.3 (24 Mar 2012 20:48:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Mar 2012 20:48:10 +0000 (UTC) Cc: darthandrus@gmail.com, 11068@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 24 21:48:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SBXse-0002HW-Nm for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 21:48:08 +0100 Original-Received: from localhost ([::1]:41868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBXse-00067z-0o for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 16:48:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBXsb-00067Q-9J for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 16:48:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBXsZ-0000FT-8C for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 16:48:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBXsZ-0000FG-4h for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 16:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SBYMX-0001sS-NM for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 17:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Mar 2012 21:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11068-submit@debbugs.gnu.org id=B11068.13326239157183 (code B ref 11068); Sat, 24 Mar 2012 21:19:01 +0000 Original-Received: (at 11068) by debbugs.gnu.org; 24 Mar 2012 21:18:35 +0000 Original-Received: from localhost ([127.0.0.1]:37256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBYM5-0001rn-PA for submit@debbugs.gnu.org; Sat, 24 Mar 2012 17:18:35 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:60718) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBYLo-0001rN-Fs for 11068@debbugs.gnu.org; Sat, 24 Mar 2012 17:18:31 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M1E00J00PN6G800@a-mtaout22.012.net.il> for 11068@debbugs.gnu.org; Sat, 24 Mar 2012 22:47:14 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.240.24]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M1E00J3WPQPA860@a-mtaout22.012.net.il>; Sat, 24 Mar 2012 22:47:14 +0200 (IST) In-reply-to: <4F6E24FD.2070907@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58103 Archived-At: > Date: Sat, 24 Mar 2012 20:48:13 +0100 > From: martin rudalics > CC: darthandrus@gmail.com, monnier@iro.umontreal.ca, > cyd@stupidchicken.com, 11068@debbugs.gnu.org > > > I don't know, I would need to see some details, like how will this > > preference be visible to the display engine. > > Via some function that extracts a valid face from a window parameter. > Actually, the only interesting thing IMO is the background attribute. I > don't think that changing any other attributes would make sense. You might be surprised what the users night want ... > But the same holds for the current patch as well: You simply fill up > the rest of the window with the background of the remapped default > face. No, not only background. The entire face with all its attributes is used. E.g., stipple (which doesn't work on MS-Windows), font (i.e. the size of each line in pixels), etc. And you cannot "fill the rest of the window" with some color, at least not on the device-independent level of the display engine where I made the changes. The only way the display engine can dictate colors (and other face attributes) is by creating glyphs which have these attributes and adding those glyphs to the current glyph matrix. What the changes I suggested do is add stretch glyphs of a suitably computed width to each glyph row that has no text in it. The changes are small because the code that does that was already written for the bidirectional display, which needs to display R2L lines flushed all the way to the right margin of the window; it does that by prepending such a stretch glyph to the R2L glyph rows, ahead (i.e to the left) of the text. All I needed was to activate that code for the case of remapped default face, in addition to R2L lines. > > Please note that the changes I've shown only notice when the `default' > > face is being remapped, they change nothing in how that default face > > is computed. So I suspect we won't be able to use the same mechanism > > to do what you want, because what you want changes the way the default > > face is computed (IIUC). > > I don't know how face remapping works so I can't tell. I thought that > remapping does recompute the default face. It does, indeed, but I didn't touch that part. I only used the already computed remapped face in a couple of places.