From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: addpm.exe missing from installation Date: Sun, 10 Jun 2012 19:03:03 +0300 Message-ID: <83wr3frw7c.fsf@gnu.org> References: <4FD4B1A2.5000502@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1339344209 7144 80.91.229.3 (10 Jun 2012 16:03:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 10 Jun 2012 16:03:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Christoph Scholtes Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 10 18:03:28 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sdkbu-0003zl-QM for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2012 18:03:26 +0200 Original-Received: from localhost ([::1]:59288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdkbu-00031k-EU for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2012 12:03:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdkbr-00031f-LS for emacs-devel@gnu.org; Sun, 10 Jun 2012 12:03:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sdkbp-0007K2-VV for emacs-devel@gnu.org; Sun, 10 Jun 2012 12:03:23 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:62776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdkbp-0007Jj-NW for emacs-devel@gnu.org; Sun, 10 Jun 2012 12:03:21 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M5E00H00SKIUF00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sun, 10 Jun 2012 19:02:56 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M5E00H0ASKW99B0@a-mtaout20.012.net.il>; Sun, 10 Jun 2012 19:02:56 +0300 (IDT) In-reply-to: <4FD4B1A2.5000502@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150878 Archived-At: > Date: Sun, 10 Jun 2012 08:39:30 -0600 > From: Christoph Scholtes > > Hi Eli, > > When building and checking the binary distribution for Emacs 24.1 I > noticed that addpm.exe was missing from the bin directory. > > This was introduced in the following change (and has slipped through the > cracks in subsequent pretest builds since 24.0.95): > > revno: 107676 > committer: Eli Zaretskii > branch nick: trunk > timestamp: Sun 2012-03-25 20:17:46 +0200 > message: > Fix parallel "make install" on MS-Windows. > > nt/makefile.w32-in (install-bin): Don't copy addpm.exe here. > > [snip] > > > The install-bin target should install all binary files in the bin folder > (incl. addpm.exe), while install-shortcuts should just _invoke_ > addpm.exe to install the shortcuts. Sorry, I don't follow: aren't you invoking "make install"? If not, what Make command are you using that doesn't work? The change I made moved addpm.exe installation from install-bin to install-shortcuts, both of which are run by "make install". The full log entry reads: * makefile.w32-in (install-bin): Don't copy addpm.exe here. Use $(DIRNAME)_same-dir.tst instead of same-dir.tst, to avoid stepping on other (parallel) Make job's toes. (install-other-dirs-nmake, install-other-dirs-gmake): Depend on `all'. (install-shortcuts): Depend on $(INSTALL_DIR)/bin. Copy addpm.exe here. (maybe-copy-distfiles-CMD, maybe-copy-distfiles-SH, dist): Depend on create-tmp-dist-dir. So copying of addpm.exe wasn't just removed, it was moved. Granted, I tested the change, and it worked for me. In general, addpm.exe is not needed, unless one wants to create or update the shortcuts, which is why I didn't hesitate to move that command (in its previous place, it interfered with parallel execution of "make install", which was the motivation for the change).