From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Note on 109327 Date: Tue, 31 Jul 2012 20:04:46 +0300 Message-ID: <83wr1jeua9.fsf@gnu.org> References: <5017D1D4.2050601@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1343754321 17212 80.91.229.3 (31 Jul 2012 17:05:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 Jul 2012 17:05:21 +0000 (UTC) Cc: dmantipov@yandex.ru, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 31 19:05:21 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SwFsn-0006vb-0y for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 19:05:21 +0200 Original-Received: from localhost ([::1]:43262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwFsm-0007f1-5w for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 13:05:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwFsg-0007e7-2b for emacs-devel@gnu.org; Tue, 31 Jul 2012 13:05:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwFsY-0008RU-QN for emacs-devel@gnu.org; Tue, 31 Jul 2012 13:05:14 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:34567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwFsY-0008N3-IO for emacs-devel@gnu.org; Tue, 31 Jul 2012 13:05:06 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0M8100600BELCX00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Tue, 31 Jul 2012 20:04:50 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M810069BBG22R40@a-mtaout22.012.net.il>; Tue, 31 Jul 2012 20:04:50 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152010 Archived-At: > From: Juanma Barranquero > Date: Tue, 31 Jul 2012 15:54:38 +0200 > Cc: Emacs development discussions > > On Tue, Jul 31, 2012 at 2:38 PM, Dmitry Antipov wrote: > > > Please report possible Windows/NS build errors as soon as possible. > > fontset.c: In function 'dump_fontset': > fontset.c:2119:6: error: 'struct frame' has no member named 'name' Which has nothing to do with Windows, but with --enable-checking. This problem, however, is more serious, IMO: gcc -I. -c -gdwarf-2 -g3 -DEMACSDEBUG -fno-crossjumping -Id:/usr/include/libxml2 -DGLYPH_DEBUG=1 -Demacs=1 -I../lib -I../nt/inc -DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -o oo/i386/w32menu.o w32menu.c w32menu.c: In function `w32_menu_show': w32menu.c:857: error: structure has no member named `title_' makefile:322: recipe for target `oo/i386/w32menu.o' failed make[1]: *** [oo/i386/w32menu.o] Error 1 AFAIU, it means that coccinelle made an incorrect replacement. I fixed both of these in revision 109332. Btw, can't we have in Emacs a feature that would allow such refactoring? The replacements don't seem too complex to me. Adding this to Emacs will both allow getting rid of an external tool, and be a valuable addition to Emacs abilities. WDYT?