all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: Lisp object that refers to a C struct
Date: Thu, 18 Oct 2012 13:17:50 +0200	[thread overview]
Message-ID: <83wqyo1129.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0SR_we+5Ge-cEZZD7OQohKm=2bnR4dBZ1Ap6rfK0dOtCmQ@mail.gmail.com>

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Thu, 18 Oct 2012 10:52:21 +0200
> Cc: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
> 
> On Thu, Oct 18, 2012 at 6:50 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > No, because, like Stephen  says, the descriptor is first validated
> > against a list of known ones.
> 
> In that case, wouldn't it be better to have the integer be an index
> into a table, like Stefan suggested?

It's easy to do that (of course, at a price of some slightly more
complicated memory management), but I think Stefan still prefers the
"new object" solution.

> It's faster to check that it is in range than compare it with an
> arbitrarily long list of known pointers.

That's not what the code does.  It calls Fassoc_quit to find the
descriptor in the list of known live watches (which will still be
needed under the table suggestion), and then validates the pointer
itself, just in case (which is also independent of the table
suggestion).



  reply	other threads:[~2012-10-18 11:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 21:24 Lisp object that refers to a C struct Eli Zaretskii
2012-10-16  1:07 ` Stefan Monnier
2012-10-16  3:53   ` Eli Zaretskii
2012-10-16 13:11     ` Stefan Monnier
2012-10-16 17:22       ` Eli Zaretskii
2012-10-16 21:43         ` Stefan Monnier
2012-10-17  4:05           ` Eli Zaretskii
2012-10-17  6:21             ` Stephen J. Turnbull
2012-10-17 15:50               ` Eli Zaretskii
2012-10-17 17:45                 ` Stephen J. Turnbull
2012-10-17 13:34             ` Stefan Monnier
2012-10-17 16:08               ` Eli Zaretskii
2012-10-17 20:23                 ` Stefan Monnier
2012-10-17 20:46                   ` Eli Zaretskii
2012-10-17 22:08                     ` Paul Eggert
2012-10-18  0:22                       ` Stefan Monnier
2012-10-18  3:43                         ` Stephen J. Turnbull
2012-10-18  4:50                       ` Eli Zaretskii
2012-10-18  7:20                         ` Paul Eggert
2012-10-18 11:09                           ` Eli Zaretskii
2012-10-18 16:42                             ` Paul Eggert
2012-10-18 17:21                               ` Eli Zaretskii
2012-10-18  8:52                         ` Juanma Barranquero
2012-10-18 11:17                           ` Eli Zaretskii [this message]
2012-10-18 12:33                             ` Stefan Monnier
2012-10-18 17:16                               ` Eli Zaretskii
2012-10-18 22:09                                 ` Stefan Monnier
2012-10-19  7:14                                   ` Eli Zaretskii
2012-10-19 14:44                                     ` Stefan Monnier
2012-10-19 18:54                                       ` Eli Zaretskii
2012-10-19 21:35                                         ` Stefan Monnier
2012-10-19 22:35                                           ` Eli Zaretskii
2012-10-20  1:52                                             ` Stefan Monnier
2012-10-20  8:34                                               ` Eli Zaretskii
2012-10-17 16:05           ` Eli Zaretskii
2012-10-17 16:59             ` Davis Herring
2012-10-17 20:27             ` Stefan Monnier
2012-10-17 21:02               ` Eli Zaretskii
2012-10-18  0:23                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wqyo1129.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.