From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFC] some reworking of struct window Date: Thu, 21 Mar 2013 20:45:10 +0200 Message-ID: <83wqt0y4ll.fsf@gnu.org> References: <514AD54F.8050309@yandex.ru> <514AF119.8080908@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1363891574 9685 80.91.229.3 (21 Mar 2013 18:46:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Mar 2013 18:46:14 +0000 (UTC) Cc: dmantipov@yandex.ru, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 21 19:46:39 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UIkVZ-0002le-IB for ged-emacs-devel@m.gmane.org; Thu, 21 Mar 2013 19:46:37 +0100 Original-Received: from localhost ([::1]:33271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIkVC-0008SH-8y for ged-emacs-devel@m.gmane.org; Thu, 21 Mar 2013 14:46:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIkV7-0008Mn-EQ for emacs-devel@gnu.org; Thu, 21 Mar 2013 14:46:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIkV3-0000Qy-Ey for emacs-devel@gnu.org; Thu, 21 Mar 2013 14:46:09 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:50180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIkV3-0000QC-5V for emacs-devel@gnu.org; Thu, 21 Mar 2013 14:46:05 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MK000I00XEHFY00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 21 Mar 2013 20:44:54 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MK000HETXETTL80@a-mtaout22.012.net.il>; Thu, 21 Mar 2013 20:44:54 +0200 (IST) In-reply-to: <514AF119.8080908@gmx.at> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158038 Archived-At: > Date: Thu, 21 Mar 2013 12:38:01 +0100 > From: martin rudalics > Cc: Emacs development discussions > > > As usual, reviews and comments are highly appreciated, especially for the > > 'struct window' member which replaces hchild/vchild/buffer (I don't like > > too generic 'object', but couldn't think up the better name). > > I'd use macros like WINDOW_BUFFER (w) and WINDOW_CHILD (w) where > appropriate to hide this detail (most callers care only about the one or > the other). I agree. And another macro for testing that a window is a leaf window.