From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFC] Add tty True Color support. Date: Wed, 16 Oct 2013 22:45:51 +0300 Message-ID: <83wqldngnk.fsf@gnu.org> References: <1804432.oj6xPZ0dh6@descartes> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1381952768 28025 80.91.229.3 (16 Oct 2013 19:46:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 16 Oct 2013 19:46:08 +0000 (UTC) Cc: emacs-devel@gnu.org To: =?utf-8?Q?R=C3=BCdiger?= Sonderfeld Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 16 21:46:12 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VWX2p-0003I1-DG for ged-emacs-devel@m.gmane.org; Wed, 16 Oct 2013 21:46:11 +0200 Original-Received: from localhost ([::1]:49106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWX2o-00015a-N8 for ged-emacs-devel@m.gmane.org; Wed, 16 Oct 2013 15:46:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWX2f-00015L-7M for emacs-devel@gnu.org; Wed, 16 Oct 2013 15:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWX2Z-0002rc-6d for emacs-devel@gnu.org; Wed, 16 Oct 2013 15:46:01 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:59146) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWX2Y-0002rY-UC for emacs-devel@gnu.org; Wed, 16 Oct 2013 15:45:55 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MUS00B001BUG500@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 16 Oct 2013 22:45:53 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MUS00BQS1KGG810@a-mtaout22.012.net.il>; Wed, 16 Oct 2013 22:45:53 +0300 (IDT) In-reply-to: <1804432.oj6xPZ0dh6@descartes> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:164251 Archived-At: > From: R=C3=BCdiger Sonderfeld > Date: Tue, 15 Oct 2013 19:24:49 +0200 >=20 > Some terminals support True Color (24bit RGB) values. At least KDE= 's > Konsole, st, and iTerm2 support it. This patch makes True Color > support available in Emacs. >=20 > So far there is no reliable way to detect True Color support in > terminals and the terminfo database lacks support. I started a > discussion on the ncurses mailing list[1]. So far only Konsole is > supported by detecting the KONSOLE_DBUS_SESSION environment variabl= e. > But this should be replaced by a more reliable method. Thanks. I might be missing something, but it looks like you didn't make any changes aimed at having display-color-cells report the correct number of colors for this type of terminal. If that is true, please add som= e code to fix that, otherwise various parts in Emacs might behave incorrectly; for starters, defface's that define colors based on how many colors are available will use the wrong colors.