all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Chris Zheng <chriszheng99@gmail.com>
Cc: 18339@debbugs.gnu.org
Subject: bug#18339: 24.4.50; Inserting '$' in TeX-mode cause Emacs crashed in MS-Windows with	trunk.
Date: Thu, 28 Aug 2014 19:31:26 +0300	[thread overview]
Message-ID: <83wq9sinj5.fsf@gnu.org> (raw)
In-Reply-To: <20140828.130721.194542882098872745.chriszheng99@gmail.com>

> Date: Thu, 28 Aug 2014 13:07:21 +0800
> From: Chris Zheng <chriszheng99@gmail.com>
> 
> From: Eli Zaretskii <eliz@gnu.org>
> Subject: Re: bug#18339: 24.4.50; Inserting '$' in TeX-mode cause Emacs crashed in MS-Windows with trunk.
> Date: Wed, 27 Aug 2014 22:46:16 +0300
> 
> > Thanks, I fixed this in trunk revision 117752.
> 
> I confirmed that this bug is fixed in trunk.  Thank you!  Is this
> change backport to 24.4 branch?  I think the same problem is in
> pretest of 24.4, too.

I installed in the trunk because I couldn't reproduce the problem in
the emacs-24 branch.  But you are right: the same faulty code is on
the branch, so I now backported the fix there (r117463).

> Also I'm quite curious why the bug wasn't found for a long period of
> time.

The buggy code examines memory 1 byte before an allocated buffer, so
the chance of that being outside the program's address space is
evidently quite small.

Memory management on Windows changed dramatically between emacs-24
branch and the trunk, so I guess this is the main reason that the bug
was exposed.





  reply	other threads:[~2014-08-28 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 18:18 bug#18339: 24.4.50; Inserting '$' in TeX-mode cause Emacs crashed in MS-Windows with trunk Chris Zheng
2014-08-27 19:46 ` Eli Zaretskii
2014-08-28  5:07   ` Chris Zheng
2014-08-28 16:31     ` Eli Zaretskii [this message]
2014-08-30 11:53       ` Chris Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wq9sinj5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=18339@debbugs.gnu.org \
    --cc=chriszheng99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.