From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: maintaining etags Date: Mon, 11 May 2015 19:50:48 +0300 Message-ID: <83wq0fkqhj.fsf@gnu.org> References: <5546DD4A.2080709@yandex.ru> <87r3qvnld1.fsf@gmail.com> <5548E08A.4090305@yandex.ru> <87mw1jndul.fsf@gmail.com> <554964CE.3040809@yandex.ru> <87oalxn756.fsf@gmail.com> <554AAD41.6060506@yandex.ru> <87vbg4lgn6.fsf@gmail.com> <554CB069.8090002@yandex.ru> <87sib7j9yf.fsf@gmail.com> <554CE8B2.7080408@yandex.ru> <87fv76kj0s.fsf@gmail.com> <83fv76p6ts.fsf@gnu.org> <831tiqox9e.fsf@gnu.org> <83twvmndr1.fsf@gnu.org> <554E0484.9010702@yandex.ru> <83mw1dophc.fsf@gnu.org> <554E8294.8070500@yandex.ru> <836180o5da.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Trace: ger.gmane.org 1431363123 29721 80.91.229.3 (11 May 2015 16:52:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 May 2015 16:52:03 +0000 (UTC) Cc: dgutov@yandex.ru, eller.helmut@gmail.com, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Francesco =?iso-8859-1?Q?Potort=EC?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 11 18:51:50 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yrqvl-0008O2-Mf for ged-emacs-devel@m.gmane.org; Mon, 11 May 2015 18:51:49 +0200 Original-Received: from localhost ([::1]:38783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrqvl-0001AW-8O for ged-emacs-devel@m.gmane.org; Mon, 11 May 2015 12:51:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrqvg-0001AO-FE for emacs-devel@gnu.org; Mon, 11 May 2015 12:51:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrqvb-0007VV-Q5 for emacs-devel@gnu.org; Mon, 11 May 2015 12:51:44 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:57456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrqvb-0007V5-Ip; Mon, 11 May 2015 12:51:39 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NO700A002ST3M00@a-mtaout21.012.net.il>; Mon, 11 May 2015 19:51:08 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NO700AF72T03800@a-mtaout21.012.net.il>; Mon, 11 May 2015 19:51:05 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186421 Archived-At: > Date: Mon, 11 May 2015 17:37:22 +0200 > From: Francesco Potort=EC > Cc: emacs-devel@gnu.org, eller.helmut@gmail.com, > Dmitry Gutov , Stefan Monnier >=20 > Eli, I see that you move around Etags's state machinery without pro= blems. I wouldn't say "without problems", it took me a while staring at the state machines to pick up enough to be able to think of a solution. That part of etags is not easily penetrated (the parts that deal with other languages are easier).=20 > Anyway, when I used to patch Etags, I always run a regression test, > then updated the regression test with the case the patch was meant = to > address. The tests that I used can be found in the tree at > , > together with some garbage. The tests are invoked from the Makefil= e as > the default target. If, as I hope, someone will care to install th= e > regression tests in the Emacs tree I can assist with answers to > questions.=20 Thanks, I will definitely run the test suite, I didn't know about it. I will also look intyo adding it to the Emacs regression suite. > The patch you propose is the sort of patch that should be run again= st a > regression test, as it is not always obvious what will happen in th= e > general case. Agreed. (I did run it on the entire Emacs tree and examined the differences one by one against the previous version, but the more the better, of course.)