From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: etags test is broken on MS-Windows Date: Fri, 22 May 2015 22:42:10 +0300 Message-ID: <83wq002yct.fsf@gnu.org> References: <83y4kmdjmj.fsf@gnu.org> <555A8E62.7060700@cs.ucla.edu> <83h9r8egen.fsf@gnu.org> <83pp5t6gex.fsf@gnu.org> <555E09AE.9070208@cs.ucla.edu> <83lhgh6fb2.fsf@gnu.org> <555E2C10.4010501@cs.ucla.edu> <83h9r5670s.fsf@gnu.org> <555E6A15.8010404@cs.ucla.edu> <831ti957wp.fsf@gnu.org> <83pp5s4uml.fsf@gnu.org> <555F740D.4030304@cs.ucla.edu> <837fs04egz.fsf@gnu.org> <87oalco1mg.fsf@igel.home> <83y4kg2yjc.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1432323758 17898 80.91.229.3 (22 May 2015 19:42:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 May 2015 19:42:38 +0000 (UTC) Cc: pot@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org To: schwab@linux-m68k.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 22 21:42:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yvspy-0007Ef-MF for ged-emacs-devel@m.gmane.org; Fri, 22 May 2015 21:42:30 +0200 Original-Received: from localhost ([::1]:35589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvspy-0008Q3-8u for ged-emacs-devel@m.gmane.org; Fri, 22 May 2015 15:42:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvspk-0008LV-Mo for emacs-devel@gnu.org; Fri, 22 May 2015 15:42:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yvsph-0001I4-0L for emacs-devel@gnu.org; Fri, 22 May 2015 15:42:16 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:38242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvspg-0001Hy-PI; Fri, 22 May 2015 15:42:12 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NOR00F00NMU4A00@mtaout29.012.net.il>; Fri, 22 May 2015 22:41:24 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOR00A89O10M650@mtaout29.012.net.il>; Fri, 22 May 2015 22:41:24 +0300 (IDT) In-reply-to: <83y4kg2yjc.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.185 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186742 Archived-At: > Date: Fri, 22 May 2015 22:38:15 +0300 > From: Eli Zaretskii > Cc: pot@gnu.org, eggert@cs.ucla.edu, emacs-devel@gnu.org > > > From: Andreas Schwab > > Cc: Paul Eggert , pot@gnu.org, emacs-devel@gnu.org > > Date: Fri, 22 May 2015 21:25:59 +0200 > > > > Eli Zaretskii writes: > > > > > These byte counts are not file byte counts (if they were, then what > > > you suggest would have been TRT). They are buffer byte counts, > > > i.e. etags needs to compute the byte counts that Emacs will see when > > > the file is visited in an Emacs buffer. So each CRLF EOL needs to be > > > counted as 1 byte, not 2. > > > > What do you do about non-ASCII characters? > > Etags counts bytes, not characters, so it doesn't matter. Or maybe I > misunderstand the question. Or maybe you mean the use case where a Latin-1 file is read into an Emacs buffer, and each non-ASCII character is expanded into a UTF-8 sequence. Indeed, that will make the byte counts inaccurate (and etags.el will have to compensate by searching around the specified place). One more reason not to change anything, I guess.