From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20802: Segfault when showing non-GTK+ tooltip Date: Tue, 16 Jun 2015 17:54:51 +0300 Message-ID: <83wpz3n1ok.fsf@gnu.org> References: <1434187118.10061.4.camel@gmx.de> <83381wq76d.fsf@gnu.org> <557C0526.5050607@gmx.at> <831thfri91.fsf@gnu.org> <557C2EF2.5030308@gmx.at> <83vberpv07.fsf@gnu.org> <557C3E1F.6030305@gmx.at> <83twubpt43.fsf@gnu.org> <557D5EE9.7070902@gmx.at> <83h9qapee0.fsf@gnu.org> <557E8B50.80905@gmx.at> <83zj41nhg9.fsf@gnu.org> <557EF6B7.3000701@gmx.at> <83fv5sop6q.fsf@gnu.org> <558024E6.6090503@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1434466626 22196 80.91.229.3 (16 Jun 2015 14:57:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Jun 2015 14:57:06 +0000 (UTC) Cc: tobias.getzner@gmx.de, 20802@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 16 16:56:55 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z4sHd-00086z-Rd for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jun 2015 16:56:14 +0200 Original-Received: from localhost ([::1]:40779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sHd-0002Fb-AJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jun 2015 10:56:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sHY-0002Bk-49 for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2015 10:56:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4sHV-0005v7-Ca for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2015 10:56:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sHV-0005uT-1l for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2015 10:56:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z4sHU-00033d-Dj for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2015 10:56:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jun 2015 14:56:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20802 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20802-submit@debbugs.gnu.org id=B20802.143446653811717 (code B ref 20802); Tue, 16 Jun 2015 14:56:04 +0000 Original-Received: (at 20802) by debbugs.gnu.org; 16 Jun 2015 14:55:38 +0000 Original-Received: from localhost ([127.0.0.1]:55941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4sH2-00032u-8i for submit@debbugs.gnu.org; Tue, 16 Jun 2015 10:55:37 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:44102) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4sGy-00032a-Ag for 20802@debbugs.gnu.org; Tue, 16 Jun 2015 10:55:33 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NQ100I00KW64Y00@mtaout25.012.net.il> for 20802@debbugs.gnu.org; Tue, 16 Jun 2015 17:50:39 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQ100IHDL8EPT10@mtaout25.012.net.il>; Tue, 16 Jun 2015 17:50:39 +0300 (IDT) In-reply-to: <558024E6.6090503@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103990 Archived-At: > Date: Tue, 16 Jun 2015 15:30:14 +0200 > From: martin rudalics > CC: tobias.getzner@gmx.de, 20802@debbugs.gnu.org > > In 32a4883..93ae9f4 master -> master I checked in a fix for X and NS > although I wasn't able to reproduce the crash on the latter (probably > due to the fact that on NS like with the native Gtk tooltips one can't > override the colors anyway). > > >> One last question: In struct image_cache we specify refcount as > >> ptrdiff_t while w32fns.c defines image_cache_refcount as int. Both > >> xfns.c and nsfns.m define image_cache_refcount as ptrdiff_t. Shouldn't > >> we uniquify this? > > > > Yes, please. The fewer differences between the various *fns.c and > > *term.c functions with similar, let alone identical names, the better. > > I made it a ptrdiff_t on Windows. Thanks.