From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21313: 25.0.50; Strange errors from dbus-handle-event Date: Sat, 03 Oct 2015 00:10:36 +0300 Message-ID: <83wpv53rjn.fsf@gnu.org> References: <877foo4nkd.fsf@gnu.org> <87wpvzs4r3.fsf@gnu.org> <87bnd9cf7g.fsf@gnu.org> <831te53zbq.fsf@gnu.org> <871te5cdg7.fsf@gnu.org> <83wpvx2h16.fsf@gnu.org> <87r3lziti9.fsf@gnu.org> <83zj0n7jtl.fsf@gnu.org> <87wpvjovfu.fsf@gnu.org> <877fnikhms.fsf@gmail.com> <87oaguq2yw.fsf@gnu.org> <8737xtt8wt.fsf@gnu.org> <834mi95bx1.fsf@gnu.org> <87twq9roxn.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1443820499 17675 80.91.229.3 (2 Oct 2015 21:14:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Oct 2015 21:14:59 +0000 (UTC) Cc: rpluim@gmail.com, 21313@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 02 23:14:44 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zi7f4-0007hl-UF for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Oct 2015 23:14:39 +0200 Original-Received: from localhost ([::1]:35227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi7f4-0003t5-DP for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Oct 2015 17:14:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi7bg-0003Wj-3W for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 17:11:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi7bb-0006kx-2I for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 17:11:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi7ba-0006ko-Uv for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 17:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Zi7ba-0003F9-H9 for bug-gnu-emacs@gnu.org; Fri, 02 Oct 2015 17:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Oct 2015 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21313-submit@debbugs.gnu.org id=B21313.144382025212450 (code B ref 21313); Fri, 02 Oct 2015 21:11:02 +0000 Original-Received: (at 21313) by debbugs.gnu.org; 2 Oct 2015 21:10:52 +0000 Original-Received: from localhost ([127.0.0.1]:52488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zi7bP-0003Ek-Cc for submit@debbugs.gnu.org; Fri, 02 Oct 2015 17:10:51 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:40255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Zi7bN-0003Eb-8u for 21313@debbugs.gnu.org; Fri, 02 Oct 2015 17:10:50 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NVM00M002JMKU00@a-mtaout22.012.net.il> for 21313@debbugs.gnu.org; Sat, 03 Oct 2015 00:10:47 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVM00MSA2TUBC90@a-mtaout22.012.net.il>; Sat, 03 Oct 2015 00:10:43 +0300 (IDT) In-reply-to: <87twq9roxn.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107230 Archived-At: > From: Tassilo Horn > Cc: rpluim@gmail.com, 21313@debbugs.gnu.org > Date: Fri, 02 Oct 2015 22:33:08 +0200 > > > I understand those commits made the situation better, perhaps even > > much better. If that's correct, I see no reason to revert them, > > I had that feeling initially but it might be completely subjective and > wrong. Maybe I just didn't write email too often on these better days, > I don't know. But the last few days were horrible again. If you feel that the changes didn't improve the situation, then reverting them is indeed TRT, IMO. At the very least, the code will be simpler after the revert. > > One idea for investigation would be to write special code that would > > collect data about these events, from the moment they are detected by > > pselect until they wind up in the D-bus handler, and put that data > > into a data structure accessible from Lisp. Then you could examine > > that data when the problem happens, and analyze it. > > Well, yes, but I have no idea how to do that. What are your difficulties? Basically, the idea is to record the last N events in some Lisp data structure. I would start with raw events as they are read from the various sources, and move higher up the "food chain" as you gather more insight into the problem. > As far as I understand, that loop that I've patched is the thing which > calls callbacks which read input from file descriptors in order to > create Dbus or file-notify events. Yes. > the thing passed to `dbus-handle-event' looks like a dbus event except > that its contents are bogus. These events are created by > xd_read_message_1 in dbusbind.c, however that function is reasonable > strict and could not create the bogus event above, e.g., it calls > make_number on the event type which becomes the second item in a > dbus-event, i.e., the CHARACTER_POSITION above which is no number. > > So what should that tell us? Either that the event was not a valid D-Bus event, or that it weasn't created by that function? Btw, dbusbind.c seems to have its own debugging facilities, so another idea would be to turn them on.