From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files Date: Wed, 21 Oct 2015 19:28:46 +0300 Message-ID: <83wpuguqwx.fsf@gnu.org> References: <20151013135354.28594.43074@vcs.savannah.gnu.org> <87io69opbs.fsf@gmail.com> <83bnc083k3.fsf@gnu.org> <871tcvks7o.fsf@gmail.com> <83si5b54m9.fsf@gnu.org> <87wpunsz6w.fsf@gmail.com> <83mvvi6fu9.fsf@gnu.org> <87wpuhud8l.fsf@gmail.com> <83r3kpfuzw.fsf@gnu.org> <87eggoxnyq.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445444962 32072 80.91.229.3 (21 Oct 2015 16:29:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Oct 2015 16:29:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Oleh Krehel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 18:29:09 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZowG7-0003ZT-JE for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 18:29:03 +0200 Original-Received: from localhost ([::1]:52781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZowG6-0002QN-Lu for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 12:29:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZowFv-0002KS-4C for emacs-devel@gnu.org; Wed, 21 Oct 2015 12:28:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZowFr-0004ij-Uv for emacs-devel@gnu.org; Wed, 21 Oct 2015 12:28:51 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:58011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZowFr-0004iM-Nh for emacs-devel@gnu.org; Wed, 21 Oct 2015 12:28:47 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NWK00L00W9FNR00@mtaout29.012.net.il> for emacs-devel@gnu.org; Wed, 21 Oct 2015 19:28:09 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWK00JTGWEW6G20@mtaout29.012.net.il>; Wed, 21 Oct 2015 19:28:09 +0300 (IDT) In-reply-to: <87eggoxnyq.fsf@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.185 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192297 Archived-At: > From: Oleh Krehel > Cc: emacs-devel@gnu.org > Date: Wed, 21 Oct 2015 17:04:13 +0200 > > I've committed this new command, turns out `dired-compress' was already > taken: > > (define-key map "c" 'dired-do-compress-to) > > Please check if I didn't end up doing something strange. Thanks, looks good to me, but the comment about non-GNU Tar has a typo. > 2. There's some autoload regeneration rule that modifies dired.el when > dired-aux.el is modified. Should that autoload be committed together > with a change? It would be nice, although Glenn has set up an automatic job for that, which runs once in a few days. > 4. I've added NEWS entries, but I forgot how the +++/---/ markers > work. Where is that info? At the beginning of the NEWS file.